[HOLD for payment 2024-11-14] [Workspace Feeds] Selecting "From the beginning" when assigning a card seems to just default to the current date

@joekaufmanexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #expensify-bugs

Action Performed:

Prerequisite:
Members and company cards added in workspace

Go to staging.new.expensify.com
Choose the workspace from settings
Click company cards >Click a Member> Assign card
Click From the beginning

Expected Result:

Start transaction date as from the beginning on the confirmation page

Actual Result:

Current date is displayed in the confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

2024-10-31_13-56-55.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @VictoriaExpensify

@VictoriaExpensify

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@VictoriaExpensify

Current assignee @VictoriaExpensify is eligible for the Bug assigner, not assigning anyone new.

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

@VickyStash

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Workspace Feeds] Update "From the beginning" option date display #52015

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

@VickyStash does not require payment (Contractor)
@DylanDylann requires payment (Needs manual offer from BZ)

@DylanDylann

@DylanDylann @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@VickyStash

Payment Summary

Upwork Job

Contributor: @VickyStash is from an agency-contributor and not due payment
ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@VictoriaExpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Go to the Workspace -> Company card section.
Start Card assignment flow > Select the employee to assign a card to > Select the card for the assignment
Select the From the beginning option as the transaction start date.
Make sure on the confirmation page the From the beginning is shown as the transaction start date.
Assign the card. Open the card details, see that the transaction start date is 90 days back from the current date.

Do we agree 👍 or 👎

Added to test rail - https://github.com/Expensify/Expensify/issues/444467

@DylanDylann

Hey @DylanDylann - I've sent you a job offer via Upwork. Could you please accept this and I'll organise payment

@VictoriaExpensify

@VictoriaExpensify No need payment. We will handle it later. Let's close

@VickyStash

@VickyStash, @mountiny, @VictoriaExpensify, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-14] [Workspace Feeds] Selecting "From the beginning" when assigning a card seems to just default to the current date #51863

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

22 remaining items

Payment Summary

BugZero Checklist (@VictoriaExpensify)

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-14] [Workspace Feeds] Selecting "From the beginning" when assigning a card seems to just default to the current date #51863

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 1, 2024

MelvinBot commented on Nov 1, 2024

melvin-bot commented on Nov 1, 2024

m-natarajan commented on Nov 1, 2024

22 remaining items

melvin-bot commented on Nov 7, 2024

melvin-bot commented on Nov 7, 2024

melvin-bot commented on Nov 14, 2024

Payment Summary

BugZero Checklist (@VictoriaExpensify)

DylanDylann commented on Nov 14, 2024

BugZero Checklist:

Regression Test Proposal

Test:

VictoriaExpensify commented on Nov 15, 2024

VictoriaExpensify commented on Nov 15, 2024

DylanDylann commented on Nov 15, 2024

melvin-bot commented on Nov 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions