[HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page

@OfstadC

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.56-3
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings > Expensify Card
Click Issue new card
Add a bank account
Dismiss the RHP
Click Issue new account
Select the added bank account
On Bank account verified page, click Got it
On Issue card page, click RHP back button

Expected Result:

The RHP will be dismissed

Actual Result:

App returns to Bank account verified page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6652488_1730477794594.bandicam_2024-11-02_00-05-53-300.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021853850206557900537
Upwork Job ID: 1853850206557900537
Last Price Increase: 2024-11-05
Automatic offers:

Nodebrute | Contributor | 104755066
rayane-djouah | Contributor | 104792968

@thienlnam

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button on issue card page returns to Bank account verified page

What is the root cause of that problem?

When user press Got it we simply navigate to next page rather then dismissing the current modal

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

Line 154 in b9ec75a

    
           onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID))}

What changes do you think we should make in order to solve the problem?

We should also dismiss the modal before navigating here. We can do something like this

   onPress={() => {
                                Navigation.dismissModal();
                                Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)); 
                            }}

It's a similar approach that we also use in other places

What alternative solutions did you explore? (Optional)

We can also use goBack() before navigating to WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW

I'm not sure if this is actually a bug or not - adding external so we can get a BZ assigned to determine whether we should fix this or not

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@rayane-djouah

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Dismiss RHP on back button click from Issue New Card page #52091

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

@rayane-djouah requires payment automatic offer (Contributor)
@Nodebrute requires payment automatic offer (Contributor)

@rayane-djouah

@rayane-djouah @OfstadC The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@rayane-djouah

@rayane-djouah Please complete the BZ checklist before the payment date. Thank you! 😃

@OfstadC

BugZero Checklist:

Regression Test Proposal

#### Precondition:

- A workspace has been created.
- The "Expensify Card" feature has been enabled on the "More features" page.

#### Test:

1. Go to workspace settings > Expensify Card
2. Click Issue new card
3. Add a bank account
4. Dismiss the RHP
5. Click Issue new card
6. Select the added bank account
7. On the "Bank account verified" page, click "Got it"
8. On the "Issue card" page, click RHP back button
9. Verify that the RHP is dismissed after clicking the back button.

Do we agree 👍 or 👎

@rayane-djouah

Test - https://github.com/Expensify/Expensify/issues/445651

Payment Summary

@rayane-djouah paid $125 via Upwork
@Nodebrute paid $125 via Upwork

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page #51883

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

55 remaining items

BugZero Checklist:

Regression Test Proposal

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page #51883

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 1, 2024

melvin-bot commented on Nov 1, 2024

github-actions commented on Nov 1, 2024

Nodebrute commented on Nov 1, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

thienlnam commented on Nov 1, 2024

melvin-bot commented on Nov 1, 2024

melvin-bot commented on Nov 1, 2024

55 remaining items

melvin-bot commented on Nov 11, 2024

melvin-bot commented on Nov 11, 2024

melvin-bot commented on Nov 11, 2024

OfstadC commented on Nov 14, 2024

rayane-d commented on Nov 15, 2024

BugZero Checklist:

Regression Test Proposal

OfstadC commented on Nov 18, 2024

Payment Summary

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions