Skip to content

[Workspace feeds] We're erroneously showing an export row when "vendor bill" is selected as the export option for QBO #51887

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Prerequisite:
Members and company cards added in workspace

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details

Expected Result:

No export row if Vendor bill is selected as the export option for QBO

Actual Result:

Export row displayed for QBO option and clicking it results in No accounts found page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence ![image - 2024-10-31T153441 380](https://github.com/user-attachments/assets/a407c5d8-7545-4750-a3ac-653ad0824864)

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 1, 2024
  2. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. m-natarajan commented on Nov 1, 2024

    @m-natarajan
    Author

    BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

  4. MelvinBot commented on Nov 1, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  5. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  6. changed the title [-]We're erroneously showing an export row when "vendor bill" is selected as the export option for QBO[/-] [+][Workspace feed] We're erroneously showing an export row when "vendor bill" is selected as the export option for QBO[/+] on Nov 1, 2024
  7. narefyev91 commented on Nov 4, 2024

    @narefyev91
    Contributor

    Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

  8. 1 remaining item

  9. DylanDylann commented on Nov 20, 2024

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: I think we don't need to comment on the previous PR because @narefyev91 also be author of this feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Prerequisite

    Members and company cards added in workspace

    Test:

    1. Choose the workspace from settings
    2. Click company cards >Card Details
    3. Verify that default export account is presented in Export row
    4. Go to Accounting > Export > Export company card expenses as > Export as. And update to Vendor Bill
    5. Back to company cards >Card Details
    6. Verify that export menu item row is not presented

    Do we agree 👍 or 👎

  10. DylanDylann commented on Nov 20, 2024

    @DylanDylann
    Contributor

    @sakluger Could you help to assign me to this issue? Because I already reviewed the PR

    Small note: PR was deployed to prod on 11/13

  11. mountiny commented on Nov 20, 2024

    @mountiny
    Contributor

    We will handle the regression testing with Joe as part of the project and payments will be all done together for the project so I think we can close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersBugSomething is broken. Auto assigns a BugZero manager.Needs ReproductionReproducible steps neededReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions