Skip to content

[HOLD for payment 2024-12-05] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" #51891

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Prerequisite:
Members and company cards added in workspace

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details

Expected Result:

When accounting integration is connected, there's default card in the card export row.

Actual Result:

When accounting integration is connected, there's no default card in the card export row.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2024-10-31T153332 628
image - 2024-10-31T153331 634
image - 2024-10-31T153318 519

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 1, 2024
  2. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. m-natarajan commented on Nov 1, 2024

    @m-natarajan
    Author

    BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

  4. MelvinBot commented on Nov 1, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  5. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  6. changed the title [-]When accounting integration is connected, there's no default in the card export row. It should be "Default card"[/-] [+][Workspace feed] When accounting integration is connected, there's no default in the card export row. It should be "Default card"[/+] on Nov 1, 2024
  7. changed the title [-][Workspace feed] When accounting integration is connected, there's no default in the card export row. It should be "Default card"[/-] [+][Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card"[/+] on Nov 4, 2024
  8. 38 remaining items

  9. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    @DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. mountiny commented on Nov 29, 2024

    @mountiny
    Contributor

    @DylanDylann can you please add a checklist?

  11. DylanDylann commented on Dec 1, 2024

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No because this seems like a case wasn't considered in document

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Choose the workspace from settings
    2. Click company cards >Card Details
    3. Verify that default export account is presented in Export row - with name "Default card"
    4. Click on menu item - Verify that "Default card" is pre-selected -> choose other export account
    5. Verify that selected export account presented in menu item row

    Do we agree 👍 or 👎

  12. melvin-bot commented on Dec 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@twisterdotcom)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. twisterdotcom commented on Dec 6, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

  14. DylanDylann commented on Dec 6, 2024

    @DylanDylann
    Contributor

    No need payment here, we will handle payment later

  15. twisterdotcom commented on Dec 9, 2024

    @twisterdotcom
    Contributor

    Cool, withdrew the one sent above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions