Skip to content

[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room #51959

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh22100010ad@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com

  2. Go to FAB > Submit expense.

  3. Enter amount > Next.

  4. Select a user that has no previous chat.

  5. Submit the expense.

  6. Go to staging.new.expensify.com

  7. Go to FAB > Start chat.

  8. Go to Room.

  9. Create a new room.

Expected Result:

App will not crash.

Actual Result:

App crashes after submitting expense to user or creating a new room.
It also crashes by just opening new chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6654428_1730734261805.20241104_225638.mp4

0411_1.txt

Bug6654428_1730734261820.20241104_224248.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 4, 2024
  2. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 27 remaining items

  7. changed the title [-][HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room[/-] [+][HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room[/+] on Nov 7, 2024
  8. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-14. 🎊

  9. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    @flodnv @slafortune The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. slafortune commented on Nov 7, 2024

    @slafortune
    Contributor

    @flodnv are you suggesting skipping the holding period and pay this out early?

  11. flodnv commented on Nov 7, 2024

    @flodnv
    Contributor

    Ah, no, not necessarily. We can wait.

  12. melvin-bot commented on Nov 14, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  13. rojiphil commented on Nov 14, 2024

    @rojiphil
    Contributor

    I believe the only remaining task here is payment for @rojiphil's C+ review

    Oh! I do not need the payment for the work here, as we can consider it part of this PR where I was the C+ reviewer.
    @slafortune We can close this out.

  14. melvin-bot commented on Nov 15, 2024

    @melvin-bot

    @flodnv, @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. melvin-bot commented on Nov 19, 2024

    @melvin-bot

    @flodnv, @slafortune Still overdue 6 days?! Let's take care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions