Repository navigation
[$250] Onboarding -Not here page is displayed after navigating back from Workspace settings #51963
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): htad26+fgfgfjhgf@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
- Sign in to the app with a new Gmail account
- Choose "Manage my team's expense" from the onboarding tasks > Finish the flow
- After finishing the onboarding flow navigate to the concierge chat
- Click on "Set up categories" from the tasks
- Click on the "Take me to workspace category settings." link
- Once you are navigated to "categories" settings, click back from the workspace settings
- Then click on the inbox tab to navigate to LHN
Expected Result:
The onboarding task page in concierge opens
Actual Result:
"Hmm... it's not here" pages opens
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6654432_1730734638967.2024-11-04_18_36_05.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021853505694132276985
- Upwork Job ID: 1853505694132276985
- Last Price Increase: 2024-11-04
Activity
melvin-bot commentedon Nov 4, 2024
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 4, 2024
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Nov 4, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Nov 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
marcochavezf commentedon Nov 4, 2024
For some reason the reportIDs for the tasks created in the onboarding list doesn't exist
I'm still investigating
marcochavezf commentedon Nov 4, 2024
We're getting the error "400 Unique Constraints Violation"
marcochavezf commentedon Nov 4, 2024
The difference between the staging/local and prod versions is that we're sending
"completedTaskReportActionID":"-1"in the payload in the former. The payload is malformed, so it's a FE error. AssigningExternallabel to get more 👀6 remaining items
marcochavezf commentedon Nov 4, 2024
Ok, this is the offending PR #51722, completedTaskReportActionID are not sent to the BE when completedTaskReportActionID is undefined, otherwise cause the unique constraints violation error
marcochavezf commentedon Nov 4, 2024
Revert #51983
DylanDylann commentedon Nov 4, 2024
@marcochavezf Hi
DylanDylann commentedon Nov 4, 2024
I think we should fix this bug on BE to adopt new value
marcochavezf commentedon Nov 4, 2024
I agree, but we should fix it before sending -1 from the FE, otherwise this bug will make it to production in the next App release.
DylanDylann commentedon Nov 4, 2024
But if we revert #51983 we will re-introduce the original issue. If this regression is more serious, I agree to revert
marcochavezf commentedon Nov 4, 2024
Hmm, that's true. Both bugs are serious because they are part of the onboarding process, and any new user will experience it. I will try to fix them in the BE, but probably the BE fix won't make it before the next App release.
If I had to choose between the two bugs, I would lean forward to fixing this one because the current cohort will experience it vs someone looking to split and chat with friends
marcochavezf commentedon Nov 4, 2024
What I found is that optimistic reportActionIDs should be 0 or any positive number. If it's 0, BE will create a new random reportActionID. For this issue, technically we shouldn't set the completedTaskReportActionID because it will mark the tasks as completed by default. For #51395, I think we'd need a backend fix
marcochavezf commentedon Nov 4, 2024
Created PR to fix #51395 in the BE. So we can continue with the revert #51983
marcochavezf commentedon Nov 4, 2024
CP
luckydaniel1993 commentedon Nov 4, 2024
@marcochavezf I just found the problem and fixed it on frontend side.
Let me post my proposal?
marcochavezf commentedon Nov 4, 2024
Oh I already reverted the offending PR @anaslancer
marcochavezf commentedon Nov 4, 2024
Tested the revert in staging and the bug is gone. Removing the deploy blocker label