[HOLD for payment 2024-11-20] [$250] Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process

@twisterdotcom

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Open the staging.new.expensify.com website.
Sign up with a new account.
Select "Manage my team´s expenses"
Complete the onboarding process selecting any option on the following steps.
Verify you land on Concierge chat and the conversation is auto scrolled to the bottom.

Expected Result:

When landing on Concierge chat, the conversation should be auto scrolled to the bottom.

Actual Result:

When selecting "Manage my team´s expenses" during onboarding process, Concierge chat is not auto scrolled to the bottom when the user is redirected to it.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6655025_1730778650817.Concierge.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021853799179762467415
Upwork Job ID: 1853799179762467415
Last Price Increase: 2024-11-05
Automatic offers:

brunovjk | Reviewer | 104756320
FitseTLT | Contributor | 104756322

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process

What is the root cause of that problem?

The root cause of the problem is we haven't provided lastVisibleActionCreated optimistically for the target chat Report here

App/src/libs/actions/Report.ts

Lines 3643 to 3651 in 210db71

    
           optimisticData.push( 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.REPORT}${targetChatReportID}`, 
        
                   value: { 
        
                       lastMentionedTime: DateUtils.getDBTime(), 
        
                       hasOutstandingChildTask, 
        
                   }, 
        
               },

What changes do you think we should make in order to solve the problem?

We need to set the lastVisibleActionCreated to last action added to the targetChatReportID optimistically
so we will set it to the last task report action timestamp and if it is not available we will set it to the video comment action otherwise to the text comment action's created timestamp.

    const lastVisibleActionCreated =
        tasksData.at(-1)?.completedTaskReportAction?.created ?? tasksData.at(-1)?.taskReportAction.reportAction.created ?? videoCommentAction?.created ?? textCommentAction.created;

    const optimisticData: OnyxUpdate[] = [...tasksForOptimisticData];
    optimisticData.push(
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${targetChatReportID}`,
            value: {
                lastMentionedTime: DateUtils.getDBTime(),
                hasOutstandingChildTask,
                lastVisibleActionCreated,
            },
        },

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021853799179762467415

@brunovjk

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

Possibly linked: #49599

Possibly linked: #49599

Nope, that is completely different issue. 👍

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process

What is the root cause of that problem?

After completing the onboard flow, we didn't notify that is a new action.

What changes do you think we should make in order to solve the problem?

At the end of completeOnboarding function (after API.write), I added notifyNewAction.
notifyNewAction(targetChatReportID, currentUserAccountID);

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: anasup1995@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Reviewing label has been removed, please complete the "BugZero Checklist".

@FitseTLT

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix - Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process #52188

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@brunovjk requires payment automatic offer (Reviewer)

@brunovjk

@brunovjk @twisterdotcom @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Tasks for guided setup #39951 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

Sign up with a new account.
Select "Manage my team´s expenses".
Complete the onboarding process selecting any option on the following steps.
Verify you land on Concierge chat and the conversation is auto scrolled to the bottom.

Do we agree 👍 or 👎

@FitseTLT

Payment Summary:

@FitseTLT paid $250 here (Contributor)
@brunovjk paid $250 here (Reviewer)

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-20] [$250] Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process #52025

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Contributor details

13 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	optimisticData.push(
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${targetChatReportID}`,
	value: {
	lastMentionedTime: DateUtils.getDBTime(),
	hasOutstandingChildTask,
	},
	},

[HOLD for payment 2024-11-20] [$250] Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process #52025

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 5, 2024

FitseTLT commented on Nov 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Nov 5, 2024

melvin-bot commented on Nov 5, 2024

twisterdotcom commented on Nov 5, 2024

FitseTLT commented on Nov 5, 2024

luckydaniel1993 commented on Nov 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Contributor details

melvin-bot commented on Nov 5, 2024

13 remaining items

melvin-bot commented on Nov 13, 2024

melvin-bot commented on Nov 13, 2024

melvin-bot commented on Nov 13, 2024

brunovjk commented on Nov 19, 2024

BugZero Checklist:

Regression Test Proposal

Test:

twisterdotcom commented on Nov 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions