Skip to content

Comprehensive unit tests and docs for LHN item presence #52031

Closed

Description

@OlimpiaZurek

Problem
LHN items have a historical record of rendering inconsistencies & regressions that lead us to a recurring question of “Why is this in my LHN?”.
There are multiple factors determining which reports should be displayed including report’s type, participants, status, specific conditions such as being pinned, having violations, or being archived which makes it easy to accidentally break this pipeline.

Solution
Implement a comprehensive unit test suite & docs around shouldReportBeInOptionList that focuses on clearly defined scenarios for report visibility. This will help us increase confidence and make sure on the CI level that no regressions in this area make it to the production environment which is not something we can guarantee ourselves right now. Here are some sample scenarios we can assert:

Should show the report

  • is expense report with outstanding violations and the report is not reimbursed
  • is currently viewing
  • has valid draft comment in the report
  • Is a self DM report
  • is marked it as pinned
  • is in focus mode and the report is unread
  • is in default mode and the report is archived

slack thread: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1727967763482779

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 5, 2024
  2. melvin-bot commented on Nov 5, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. RachCHopkins commented on Nov 5, 2024

    @RachCHopkins
    Contributor
  4. added
    PlanningChanges still in the thought process
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 5, 2024
  5. melvin-bot commented on Nov 11, 2024

    @melvin-bot

    Eep! 4 days overdue now. Issues have feelings too...

  6. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Still overdue 6 days?! Let's take care of this!

  7. melvin-bot commented on Nov 15, 2024

    @melvin-bot

    8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  8. melvin-bot commented on Nov 19, 2024

    @melvin-bot

    12 days overdue now... This issue's end is nigh!

  9. melvin-bot commented on Nov 22, 2024

    @melvin-bot

    This issue has not been updated in over 14 days. eroding to Weekly issue.

  10. 2 remaining items

  11. mountiny commented on Dec 2, 2024

    @mountiny
    Contributor

    We are chugging along on these

  12. mountiny commented on Dec 12, 2024

    @mountiny
    Contributor

    in progress

  13. mountiny commented on Dec 26, 2024

    @mountiny
    Contributor

    This was for tracking and the last issue open is this one #52034 and the PR for it was just merged so I think we can close this one and consider it concluded #53745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

PlanningChanges still in the thought processWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions