You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Comprehensive unit tests and docs for LHN item presence #52031
Problem
LHN items have a historical record of rendering inconsistencies & regressions that lead us to a recurring question of “Why is this in my LHN?”.
There are multiple factors determining which reports should be displayed including report’s type, participants, status, specific conditions such as being pinned, having violations, or being archived which makes it easy to accidentally break this pipeline.
Solution
Implement a comprehensive unit test suite & docs around shouldReportBeInOptionList that focuses on clearly defined scenarios for report visibility. This will help us increase confidence and make sure on the CI level that no regressions in this area make it to the production environment which is not something we can guarantee ourselves right now. Here are some sample scenarios we can assert:
Should show the report
is expense report with outstanding violations and the report is not reimbursed
This was for tracking and the last issue open is this one #52034 and the PR for it was just merged so I think we can close this one and consider it concluded #53745
Activity
melvin-bot commentedon Nov 5, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.RachCHopkins commentedon Nov 5, 2024
Expensify slack thread for convenience: https://expensify.slack.com/archives/C05LX9D6E07/p1727967763482779
melvin-bot commentedon Nov 11, 2024
Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Nov 13, 2024
Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Nov 15, 2024
8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Nov 19, 2024
12 days overdue now... This issue's end is nigh!
melvin-bot commentedon Nov 22, 2024
This issue has not been updated in over 14 days. eroding to Weekly issue.
2 remaining items
mountiny commentedon Dec 2, 2024
We are chugging along on these
mountiny commentedon Dec 12, 2024
in progress
mountiny commentedon Dec 26, 2024
This was for tracking and the last issue open is this one #52034 and the PR for it was just merged so I think we can close this one and consider it concluded #53745