Repository navigation
[HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error #52096
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh2610001@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace settings > Workflows.
- Click Connect bank account.
- Click Connect manually.
- Proceed to "What's your company’s website?".
- Enter an invalid website to trigger the error.
- Note that the error mentions "Please enter a valid website using lower-case letters.".
- Enter a website using upper-case letters.
- Click Next.
Expected Result:
App will not proceed to the next page because the error mentions that the website must be in lower-case letters (production behavior).
Actual Result:
App proceeds to the next page when using upper-case letters despite the error.
The error message should be updated if this is the expected behavior.
The same validation message also happens in Invoice company website page.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6656059_1730858126541.20241106_095110.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021854108988948033314
- Upwork Job ID: 1854108988948033314
- Last Price Increase: 2024-11-06
- Automatic offers:
- suneox | Reviewer | 104768561
- ahmedGaber93 | Contributor | 104768562
Activity
melvin-bot commentedon Nov 6, 2024
Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 6, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 6, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 6, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
NJ-2020 commentedon Nov 6, 2024
Offending PR: #51545
We convert the url to lowercase when checking inside the validation function
App/src/pages/ReimbursementAccount/BusinessInfo/substeps/WebsiteBusiness.tsx
Line 37 in 573162f
it should be:
Krishna2323 commentedon Nov 6, 2024
I will raise PR for this, probably in a hour or two.
29 remaining items
melvin-bot commentedon Nov 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 7, 2024
@suneox / @ahmedGaber93 @abekkala The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error[/-][+][HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error[/+]melvin-bot commentedon Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 11, 2024
@suneox / @ahmedGaber93 @abekkala The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error[/-][+][HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error[/+]abekkala commentedon Nov 13, 2024
@Julesssss & @ahmedGaber93
I just reviewed the PR - can you confirm that it was @Krishna2323, not @suneox that created the fix?
To me the payouts appear to be:
Which differs from the melvin message above
Krishna2323 commentedon Nov 13, 2024
@abekkala, this was a regression, so no payment needed here.
abekkala commentedon Nov 13, 2024
aaaah ok ok - thanks @Krishna2323