Repository navigation
[HOLD for payment 2024-11-21] QAB - Scan QAB is not displayed for offline created workspace #52186
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #51836
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
- Sign up with a new account
- Apply offline network
- Create a workspace
- Click on FAB
- Apply online network
Expected Result:
On step 4, a Scan receipt QAB should be displayed pointing to the newly created workspace
Actual Result:
There is no Scan receipt QAB
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Nov 7, 2024
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 7, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 7, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 7, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
25 remaining items
OfstadC commentedon Nov 21, 2024
Or - actually I think @ishpaul777 would be responsible for the BZ checklist 😅 Sorry about that!
dukenv0307 commentedon Nov 22, 2024
@OfstadC It's the regression of #50728. So I don't think we need to pay cc @ishpaul777
ishpaul777 commentedon Nov 22, 2024
not technically a regression, root cause was different we did not touched any logic for
nvp_expensify_activePolicyIDand solution was out of scope from the previous PR, i'll let @puneetlath assess the situation as he was CME on the previous PR, I am fine with any decision he'll make.ishpaul777 commentedon Nov 22, 2024
Neverthless, a regression test for this would be nice to have
Regression Test Proposal:
Do we agree 👍 or 👎
OfstadC commentedon Nov 22, 2024
Regression Test Issue
OfstadC commentedon Nov 22, 2024
Thanks @ishpaul777 - I'll hold payment here until @puneetlath weighs in. I believe they are out today -- so if you prefer, I can raise a Slack discussion to decide on payment sooner if you'd like?
I can confirm Payment Summary for @dukenv0307 is accurate.
puneetlath commentedon Nov 22, 2024
I don't think it's a regression. It wasn't part of the scope for the original, so I think we should pay everyone out on this one.
OfstadC commentedon Nov 22, 2024
Perfect! Thanks @puneetlath 😃
OfstadC commentedon Nov 22, 2024
@ishpaul777 Offer sent
ishpaul777 commentedon Nov 23, 2024
Thank you! @puneetlath @OfstadC. I have accepted the offer 🙇
JmillsExpensify commentedon Nov 25, 2024
$250 approved for @dukenv0307
OfstadC commentedon Nov 25, 2024
Updated Payment Summary - All set here 😃
Thanks everyone!