Repository navigation
[HOLD for payment 2024-11-20] [$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace #52201
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+zm27@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Create a new workspace
- Go to More features
- Enable Per diem
- Tap Upgrade
- On upgrade success screen, tap View your subscription
Expected Result:
App will open subscription page
Actual Result:
App opens subscription page and then opens workspace editor page quickly.
This issue only happens when upgrading workspace to Control from Per diem feature
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6657766_1730994753153.ScreenRecording_11-07-2024_23-47-45_1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021854641998677095618
- Upwork Job ID: 1854641998677095618
- Last Price Increase: 2024-11-07
- Automatic offers:
- truph01 | Contributor | 104804112
Activity
melvin-bot commentedon Nov 7, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 7, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 7, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]mweb - Per diem - View your subscription link opens Subscription page then back to Workspace[/-][+][$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace[/+]melvin-bot commentedon Nov 7, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021854641998677095618
19 remaining items
[-][$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace[/-][+][HOLD for payment 2024-11-20] [$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace[/+]melvin-bot commentedon Nov 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 13, 2024
@ntdiary @sakluger @ntdiary The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sakluger commentedon Nov 19, 2024
@ntdiary payment is due tomorrow, please complete the BZ checklist by tomorrow. Thanks!
ntdiary commentedon Nov 20, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51232/files#r1850266676
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. No need
This is an edge case that was overlooked during feature development. I think it's sufficient to commen on the original PR. :)
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
sakluger commentedon Nov 20, 2024
Thanks everyone!
Summarizing payment on this issue:
Contributor: @truph01 $250, paid via Upwork
Contributor+: @ntdiary $250, please request on Newdot
JmillsExpensify commentedon Nov 21, 2024
$250 approved for @ntdiary