Skip to content

[HOLD for payment 2024-11-28] [$250] Search - Search icon is not responsive after sharing expense with accountant and return to LHN #52239

New issue
New issue
Closed
Closed
[HOLD for payment 2024-11-28] [$250] Search - Search icon is not responsive after sharing expense with accountant and return to LHN#52239
Assignees
allroundexpertstechievivekzanyrenneymkzie2
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Nov 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+zm27@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to self DM.
  3. Track a manual expense.
  4. Go to Search.
  5. Tap on the track expense in Step 3.
  6. Open report header.
  7. Tap Share it with my accountant.
  8. Select a workspace, enter merchant and submit.
  9. Swipe to the right (iOS navigation, not app back button) twice to return to LHN.
  10. Tap on the search icon.

Expected Result:

Search icon will be responsive after sharing expense with accountant from Search and returning to LHN.

Actual Result:

Search icon is not responsive after sharing expense with accountant from Search and returning to LHN.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6658607_1731056488090.ScreenRecording_11-08-2024_16-56-22_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021855821019880549411
  • Upwork Job ID: 1855821019880549411
  • Last Price Increase: 2024-11-11
  • Automatic offers:
    • mkzie2 | Contributor | 104839852
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 8, 2024

  2. melvin-bot commented on Nov 8, 2024

    @melvin-bot
    melvin-botBot
    on Nov 8, 2024 – with Melvin Bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot
    assigned
    zanyrenney
    and
    techievivek
    on Nov 8, 2024
  4. melvin-bot
    added
    DailyKSv2
    on Nov 8, 2024

  5. melvin-bot commented on Nov 8, 2024

    @melvin-bot
    melvin-botBot
    on Nov 8, 2024 – with Melvin Bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot commented on Nov 8, 2024

    @melvin-bot
    melvin-botBot
    on Nov 8, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Nov 8, 2024

  8. github-actions commented on Nov 8, 2024

    @github-actions
    github-actionsBot
    on Nov 8, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. zanyrenney commented on Nov 8, 2024

    @zanyrenney
    zanyrenney
    on Nov 8, 2024
    Contributor

    Hey Vivek, how is this one going? Let me know if I can help at all or if you need anything tested.

  10. Julesssss
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Nov 8, 2024

  11. 28 remaining items

  12. melvin-bot commented on Nov 21, 2024

    @melvin-bot
    melvin-botBot
    on Nov 21, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 21, 2024

    @melvin-bot
    melvin-botBot
    on Nov 21, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-28. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Nov 21, 2024

    @melvin-bot
    melvin-botBot
    on Nov 21, 2024 – with Melvin Bot

    @allroundexperts @zanyrenney @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Nov 27, 2024

  16. zanyrenney commented on Nov 28, 2024

    @zanyrenney
    zanyrenney
    on Nov 28, 2024
    Contributor

    payment summary

    @allroundexperts requires payment through NewDot Manual Requests - please request $250
    @mkzie2 requires payment automatic offer (Contributor) - paid $250 via Upwork.

  17. zanyrenney
    closed this as completedon Nov 28, 2024
  18. zanyrenney
    reopened this on Nov 28, 2024

  19. zanyrenney commented on Nov 28, 2024

    @zanyrenney
    zanyrenney
    on Nov 28, 2024
    Contributor

    @allroundexperts please can you complete the checklist before getting the ND payment? Thanks!

  20. allroundexperts commented on Nov 28, 2024

    @allroundexperts
    allroundexperts
    on Nov 28, 2024
    Contributor

    Checklist

    1. Add Track expense follow up questions as rows in details view of a Tracked expense #51951
    2. https://github.com/Expensify/App/pull/51951/files#r1862758035
    3. N/A
    4. A regression test would be helpful.

    Regression test

    1. Launch the app and Go to self DM.
    2. Track a manual expense.
    3. Go to Search and Tap on the expense created earlier.
    4. Open report header.
    5. Tap Share it with my accountant.
    6. Select a workspace, enter merchant and submit.
    7. Press the physical back button (on Android) or Swipe right (on iOS) twice to return to LHN.
    8. Tap on the search icon.

    Verify that the search icon will be responsive after sharing expense with accountant from Search and returning to LHN.

    Do we 👍 or 👎 ?

  21. techievivek commented on Nov 29, 2024

    @techievivek
    techievivek
    on Nov 29, 2024
    Contributor

    Regression tests looks good to me.

  22. zanyrenney commented on Nov 29, 2024

    @zanyrenney
    zanyrenney
    on Nov 29, 2024
    Contributor

    https://github.com/Expensify/Expensify/issues/448689

  23. zanyrenney commented on Nov 29, 2024

    @zanyrenney
    zanyrenney
    on Nov 29, 2024
    Contributor

    Complete!

  24. zanyrenney
    closed this as completedon Nov 29, 2024

  25. JmillsExpensify commented on Jun 10, 2025

    @JmillsExpensify
    JmillsExpensify
    on Jun 10, 2025
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions