[Workspace Feeds] RemoveFeed command fails #52252

Activity

1. mountiny

   added

   DailyKSv2KSv2

   InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staff

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   on Nov 8, 2024
2. mountiny

   self-assigned this

   on Nov 8, 2024
3. mountiny

   added this to [#whatsnext] #qualityon Nov 8, 2024
4. github-project-automation

   added this to [wave-collect] Workspace Feedson Nov 8, 2024
5. melvin-bot

   assigned

   johncschuster

   on Nov 8, 2024
6. melvin-bot commented on Nov 8, 2024

   

   melvin-botBot

   on Nov 8, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
7. mountiny commented on Nov 8, 2024

   

   mountiny

   on Nov 8, 2024

   ContributorAuthor

   More actions

   Here are some logs https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=request_id%3A%228df583fe0b723bc4-WAW%22%20AND%20timestamp%3A%5B2024-11-08T00%3A00%20TO%202024-11-09T23%3A59%5D
8. mountiny commented on Nov 8, 2024

   

   mountiny

   on Nov 8, 2024

   ContributorAuthor

   More actions

   This is failing because the feed is pending so there is no CompanyID NVP for the feed. Gonna have to update that.

   then the next thing is that the RemoveFeed command is not removing the feed from the comapnyCards settings in domain_member and it should
9. mountiny commented on Nov 10, 2024

   

   mountiny

   on Nov 10, 2024

   ContributorAuthor

   More actions

   Working on this one
10. mountiny

    added

    ReviewingHas a PR in reviewHas a PR in review

    on Nov 12, 2024
11. mountiny commented on Nov 12, 2024

    

    mountiny

    on Nov 12, 2024

    ContributorAuthor

    More actions

    PR in review
12. mountiny commented on Nov 12, 2024

    

    mountiny

    on Nov 12, 2024

    ContributorAuthor

    More actions

    Merged
13. garrettmknight

    added this to #expensify-bugson Nov 12, 2024
14. garrettmknight

    moved this to Bugs and Follow Up Issues in #expensify-bugson Nov 12, 2024
15. garrettmknight

    removed this from [#whatsnext] #qualityon Nov 12, 2024
16. mountiny commented on Nov 13, 2024

    

    mountiny

    on Nov 13, 2024

    ContributorAuthor

    More actions

    Created one more follow up
17. mountiny commented on Nov 20, 2024

    

    mountiny

    on Nov 20, 2024

    ContributorAuthor

    More actions

    Another small PR out and deployed
18. mountiny

    moved this from MEDIUM to HIGH in [wave-collect] Workspace Feedson Nov 20, 2024
19. joekaufmanexpensify commented on Nov 21, 2024

    

    joekaufmanexpensify

    on Nov 21, 2024

    Contributor

    More actions

    Noting that I tested here and it works well when there's only one feed. Still not 100% right when there are multiple feeds though.

    LMK when this is ready to retest!
20. mountiny commented on Nov 21, 2024

    

    mountiny

    on Nov 21, 2024

    ContributorAuthor

    More actions

    @joekaufmanexpensify That is a frontend-only issue; the feed is removed, but we are not navigating/ showing another one upon deletion. It is handled here #52893

    Given the backend changes for this are done, I think we can close this issue
21. mountiny

    closed this as completedon Nov 21, 2024
22. github-project-automation

    moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Nov 21, 2024
23. github-project-automation

    moved this from HIGH to Done in [wave-collect] Workspace Feedson Nov 21, 2024
24. joekaufmanexpensify commented on Nov 21, 2024

    

    joekaufmanexpensify

    on Nov 21, 2024

    Contributor

    More actions

    Sweet, sounds good. TY!