Repository navigation
[PAID] [$250] Expense - Disabled category when selected is not highlighted #52259
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+kh271000026@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat.
- Submit an expense with category.
- Go to workspace settings > Categories.
- Disable all the categories.
- Go to workspace chat.
- Go to the transaction thread (from Step 3).
- Click Category.
Expected Result:
The disabled category when selected should be highlighted (production behavior).
Actual Result:
The disabled category when selected is not highlighted.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6658843_1731071204219.20241108_210046.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021854920252783122362
- Upwork Job ID: 1854920252783122362
- Last Price Increase: 2024-11-08
- Automatic offers:
- rayane-djouah | Contributor | 104839950
Activity
melvin-bot commentedon Nov 8, 2024
Triggered auto assignment to @flodnv (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 8, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 8, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Expense - Disabled category when selected is not highlighted[/-][+][$250] Expense - Disabled category when selected is not highlighted[/+]melvin-bot commentedon Nov 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021854920252783122362
24 remaining items
melvin-bot commentedon Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 11, 2024
@rayane-djouah @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-11-18] [$250] Expense - Disabled category when selected is not highlighted[/-][+][HOLD for payment 2024-11-20] [HOLD for payment 2024-11-18] [$250] Expense - Disabled category when selected is not highlighted[/+]melvin-bot commentedon Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 13, 2024
@rayane-djouah @strepanier03 @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rayane-d commentedon Nov 15, 2024
BugZero Checklist:
Classify the bug:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51988/files#r1844657870
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
@strepanier03 Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/445572
Regression Test Proposal
Do we agree 👍 or 👎
[-][HOLD for payment 2024-11-20] [HOLD for payment 2024-11-18] [$250] Expense - Disabled category when selected is not highlighted[/-][+][Payment 2024-11-18] [$250] Expense - Disabled category when selected is not highlighted[/+]strepanier03 commentedon Nov 18, 2024
@rayane-djouah - Thanks for the checklist! I've paid and closed the contract for you in Upwork.
@MuaazArshad - I have sent you an offer, I'll check again later today to see if I can pay it.
strepanier03 commentedon Nov 19, 2024
Thanks @MuaazArshad - I've paid and closed your contract. 👋
[-][Payment 2024-11-18] [$250] Expense - Disabled category when selected is not highlighted[/-][+][PAID] [$250] Expense - Disabled category when selected is not highlighted[/+]