[HOLD for payment 2024-11-29] [$250] Search - The shortcut CTRL + K does not work with a user as employee in a WS

@abekkala

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5191872
Issue reported by: Applause - Internal Team

Action Performed:

Sign in to the app with a new Gmail account
Choose "Get paid back by my employer" from the onboarding tasks
Type a Name and Last name and click the "Continue" button
Go to Settings, create a new workspace and invite a new account as an employee
Log in with the new employee's account in incognito mode
Press the shortcut CTRL + K to open search dialog

Expected Result:

The shortcut CTRL + K to open the search dialog should open correctly

Actual Result:

Pressing the combination CTRL + K to open the search dialog does not execute, while the other shortcuts such as CTRL + J and CTRL + D work correctly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6658921_1731075276789.Ctrl___k_doesn_t_Work.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021854902169710515284
Upwork Job ID: 1854902169710515284
Last Price Increase: 2024-11-13
Automatic offers:

dukenv0307 | Contributor | 104806147
truph01 | Contributor | 104867213

Issue Owner

Current Issue Owner: @abekkala

@danieldoglas

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@daledah

I ran into this problem in production already cc @daledah I believe someone pointed to your PR here #51547 any chance you could have a look?

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny

@mountiny I want to confirm this: If an account is created optimistically by another user (for this issue, the account is created by search), then when logging in, this account will not have to go through onboarding steps. Is that correct?

@dukenv0307

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment automatic offer (Contributor)
@truph01 requires payment automatic offer (Contributor)

@dukenv0307

@dukenv0307 @abekkala @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: The offending PR is reverted, we use the new approach
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Log in with any account in incognito mode
Turn on console and type: Onyx.set('nvp_onboarding', '{"selfTourViewed": true}');
Press the shortcut CTRL + K to open search dialog
Verify he shortcut CTRL + K to open the search dialog should open correctly

Do we agree 👍 or 👎

I am not sure if we need such test

@truph01

PAYMENT SUMMARY FOR NOV 29

Fix: @truph01 [$250]offer (Contributor)
PR Review: @dukenv0307 [$250] offer (Contributor)

@truph01

@truph01 payment sent and contract ended - thank you! 🎉

@dukenv0307

@dukenv0307 waiting for acceptance of offer in Upwork - thanks!

@abekkala

@abekkala I have requested ND payment. The Upwork offer is not needed. Thanks!

@dukenv0307

@dukenv0307 Ah ok, I see you were just added to NewDot payments on Nov 19. (But the auto offer was sent still by melvin)

thanks!

PAYMENT SUMMARY

@dukenv0307 [$250]

@dukenv0307

$250 approved for @dukenv0307

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-29] [$250] Search - The shortcut CTRL + K does not work with a user as employee in a WS #52260

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

89 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

PAYMENT SUMMARY FOR NOV 29

PAYMENT SUMMARY

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-29] [$250] Search - The shortcut CTRL + K does not work with a user as employee in a WS #52260

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 8, 2024

melvin-bot commented on Nov 8, 2024

github-actions commented on Nov 8, 2024

mountiny commented on Nov 8, 2024

melvin-bot commented on Nov 8, 2024

daledah commented on Nov 8, 2024

89 remaining items

melvin-bot commented on Nov 22, 2024

melvin-bot commented on Nov 22, 2024

dukenv0307 commented on Nov 25, 2024

BugZero Checklist:

Regression Test Proposal

Test:

mountiny commented on Nov 25, 2024

abekkala commented on Nov 26, 2024

PAYMENT SUMMARY FOR NOV 29

abekkala commented on Nov 29, 2024

abekkala commented on Nov 29, 2024

dukenv0307 commented on Dec 1, 2024

abekkala commented on Dec 2, 2024

PAYMENT SUMMARY

JmillsExpensify commented on Dec 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions