You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HybridApp] Update the force upgrade modal to distinguish between prod and staging environments. #52276
When we deprecate the NewDot standalone app, it causes us to not be able to test whether bugs are /app or /mobile, which prevents us from confirming if the issue can be external or internal.
Why is this important?
To protect internal engineering resources and maximise the use of our external contributors. This is also a blocker to deprecating the app, which increasingly causing more confusion amongst users.
Solution
Update the force upgrade modal to distinguish between staging and production environments.
Force upgrade production only, pointing the "Upgrade" CTA to the "Expensify" HybridApp listing in the app store.
In doing so, we can continue shipping NewDot standalone builds to staging environments (i.e Testflight) and maintain our ability to test for HybridApp only bugs.
I don't think (2) is required for this issue. We need to force upgrade production users of the NewDot app, and keep shipping new builds to staging such that we can continue testing bugs to determine if they're HybridApp only or not.
In this case I think we can take care of that when we'll align the HybridApp deployment to NewDot! When it happens we can take care of that, so it doesn't happen to soon 😄
Activity
trjExpensify commentedon Nov 13, 2024
Asking about next steps here. CC: @staszekscp
staszekscp commentedon Nov 13, 2024
Just to confirm the scope of the task 😄 The desired behaviour is to:
Force upgrademodal to production users on NewDot, with a CTA to download HybridApptrjExpensify commentedon Nov 13, 2024
I don't think (2) is required for this issue. We need to force upgrade production users of the NewDot app, and keep shipping new builds to staging such that we can continue testing bugs to determine if they're HybridApp only or not.
staszekscp commentedon Nov 14, 2024
In this case I think we can take care of that when we'll align the HybridApp deployment to NewDot! When it happens we can take care of that, so it doesn't happen to soon 😄
trjExpensify commentedon Nov 15, 2024
Cool, I think we just merged that PR didn't we? #52283
34 remaining items
trjExpensify commentedon Dec 9, 2024
Still held up on confirming this.
melvin-bot commentedon Dec 13, 2024
@Julesssss, @trjExpensify, @war-in Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Julesssss commentedon Dec 13, 2024
trjExpensify commentedon Dec 16, 2024
Thanks!
melvin-bot commentedon Dec 20, 2024
@Julesssss, @trjExpensify, @war-in Whoops! This issue is 2 days overdue. Let's get this updated quick!
trjExpensify commentedon Dec 20, 2024
@Julesssss how do you feel about closing this now?
Julesssss commentedon Dec 20, 2024
Thanks, yeah as shown here the force upgrade flow is working nicely. We have a separate error with how referer is being reported.