Skip to content

[HybridApp] Update the force upgrade modal to distinguish between prod and staging environments.  #52276

Closed

Description

@trjExpensify

Coming from here.
Parent issue

Problem

When we deprecate the NewDot standalone app, it causes us to not be able to test whether bugs are /app or /mobile, which prevents us from confirming if the issue can be external or internal.

Why is this important?

To protect internal engineering resources and maximise the use of our external contributors. This is also a blocker to deprecating the app, which increasingly causing more confusion amongst users.

Solution

  • Update the force upgrade modal to distinguish between staging and production environments.
  • Force upgrade production only, pointing the "Upgrade" CTA to the "Expensify" HybridApp listing in the app store.

In doing so, we can continue shipping NewDot standalone builds to staging environments (i.e Testflight) and maintain our ability to test for HybridApp only bugs.

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 8, 2024
  2. self-assigned this
    on Nov 8, 2024
  3. self-assigned this
    on Nov 11, 2024
  4. trjExpensify commented on Nov 13, 2024

    @trjExpensify
    ContributorAuthor

    Asking about next steps here. CC: @staszekscp

  5. staszekscp commented on Nov 13, 2024

    @staszekscp
    Contributor

    Just to confirm the scope of the task 😄 The desired behaviour is to:

    1. Present the Force upgrade modal to production users on NewDot, with a CTA to download HybridApp
    2. Distinguish production and staging on HybridApp (since we don't do it at the moment)
  6. trjExpensify commented on Nov 13, 2024

    @trjExpensify
    ContributorAuthor

    I don't think (2) is required for this issue. We need to force upgrade production users of the NewDot app, and keep shipping new builds to staging such that we can continue testing bugs to determine if they're HybridApp only or not.

  7. staszekscp commented on Nov 14, 2024

    @staszekscp
    Contributor

    In this case I think we can take care of that when we'll align the HybridApp deployment to NewDot! When it happens we can take care of that, so it doesn't happen to soon 😄

  8. trjExpensify commented on Nov 15, 2024

    @trjExpensify
    ContributorAuthor

    Cool, I think we just merged that PR didn't we? #52283

  9. 34 remaining items

  10. trjExpensify commented on Dec 9, 2024

    @trjExpensify
    ContributorAuthor

    Still held up on confirming this.

  11. melvin-bot commented on Dec 13, 2024

    @melvin-bot

    @Julesssss, @trjExpensify, @war-in Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. Julesssss commented on Dec 13, 2024

    @Julesssss
    Contributor
  13. trjExpensify commented on Dec 16, 2024

    @trjExpensify
    ContributorAuthor

    Thanks!

  14. melvin-bot commented on Dec 20, 2024

    @melvin-bot

    @Julesssss, @trjExpensify, @war-in Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. trjExpensify commented on Dec 20, 2024

    @trjExpensify
    ContributorAuthor

    @Julesssss how do you feel about closing this now?

  16. Julesssss commented on Dec 20, 2024

    @Julesssss
    Contributor

    Thanks, yeah as shown here the force upgrade flow is working nicely. We have a separate error with how referer is being reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions