You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-17] Add Posted: for filtering card transactions by statement dates #52376
We missed adding this filter in the Search v2 design doc, so let's add it now. Like other date filters, it'll accept YYYY-MM-DD and will apply exclusively to the Expensify Card.
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️
@JmillsExpensify should this filter name also follow the other date-based filter and be just posted: instead of datePosted:? We are using submitted, approved, etc for the other ones
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Nov 12, 2024
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.
melvin-bot commentedon Nov 12, 2024
melvin-bot commentedon Nov 12, 2024
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)dannymcclain commentedon Nov 12, 2024
@JmillsExpensify will
datePosted:accept bothbeforeandaftervalues like our regular date filter?JmillsExpensify commentedon Nov 18, 2024
Hmm, good question. We should probably take that approach for consistency.
luacmartins commentedon Nov 21, 2024
@JmillsExpensify should this filter name also follow the other date-based filter and be just
posted:instead ofdatePosted:? We are usingsubmitted,approved, etc for the other onesJmillsExpensify commentedon Nov 21, 2024
Ah, great call. I like that, updated the OP.
16 remaining items
melvin-bot commentedon Dec 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-17. 🎊
melvin-bot commentedon Dec 10, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Dec 17, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Dec 20, 2024
@JmillsExpensify, @dannymcclain, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 24, 2024
@JmillsExpensify, @dannymcclain, @luacmartins Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Dec 26, 2024
@JmillsExpensify, @dannymcclain, @luacmartins 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Dec 30, 2024
@JmillsExpensify, @dannymcclain, @luacmartins 12 days overdue. Walking. Toward. The. Light...
luacmartins commentedon Dec 30, 2024
Payment was handled via #52262. Closing.