Skip to content

[HOLD for payment 2024-12-17] Add Posted: for filtering card transactions by statement dates #52376

Closed

Description

@JmillsExpensify

We missed adding this filter in the Search v2 design doc, so let's add it now. Like other date filters, it'll accept YYYY-MM-DD and will apply exclusively to the Expensify Card.

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    NewFeatureSomething to build that is a new item.
    on Nov 12, 2024
  2. melvin-bot commented on Nov 12, 2024

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  3. melvin-bot commented on Nov 12, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Nov 12, 2024

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  5. dannymcclain commented on Nov 12, 2024

    @dannymcclain
    Contributor

    @JmillsExpensify will datePosted: accept both before and after values like our regular date filter?

  6. JmillsExpensify commented on Nov 18, 2024

    @JmillsExpensify
    ContributorAuthor

    Hmm, good question. We should probably take that approach for consistency.

  7. luacmartins commented on Nov 21, 2024

    @luacmartins
    Contributor

    @JmillsExpensify should this filter name also follow the other date-based filter and be just posted: instead of datePosted:? We are using submitted, approved, etc for the other ones

  8. JmillsExpensify commented on Nov 21, 2024

    @JmillsExpensify
    ContributorAuthor

    Ah, great call. I like that, updated the OP.

  9. 16 remaining items

  10. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-17. 🎊

  11. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  12. melvin-bot commented on Dec 17, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  13. melvin-bot commented on Dec 20, 2024

    @melvin-bot

    @JmillsExpensify, @dannymcclain, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    @JmillsExpensify, @dannymcclain, @luacmartins Still overdue 6 days?! Let's take care of this!

  15. melvin-bot commented on Dec 26, 2024

    @melvin-bot

    @JmillsExpensify, @dannymcclain, @luacmartins 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  16. melvin-bot commented on Dec 30, 2024

    @melvin-bot

    @JmillsExpensify, @dannymcclain, @luacmartins 12 days overdue. Walking. Toward. The. Light...

  17. luacmartins commented on Dec 30, 2024

    @luacmartins
    Contributor

    Payment was handled via #52262. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions