Repository navigation
iOS / Android - Request money page breaks after using 14 digits #5241
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue is failing PR #5192 (CC @akshayasalvi @marcaaron @deetergp)
Action Performed
- Launch the app and log in with any account
- Go to any transaction option - Split Money or Request Money
- Search for ALL currency
- Go to the number pad and try to type a very long number - say 14+ digits.
Expected Result
Request money page looks properly aligned after using 14 digits
Actual Result
Request money page breaks after using 14 digits
Platform
iOS ✔️
Android ✔️
Version Number: 1.0.98-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Images/Video
Bug5235387_Screen_Recording_20210913-171127_New_Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Activity
MelvinBot commentedon Sep 14, 2021
Triggered auto assignment to @ctkochan22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.OSBotify commentedon Sep 14, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:francoisl commentedon Sep 14, 2021
I feel like the simplest fix would be to cap the size of the amount you can enter to 10 digits? I think that's the max we allow in the backend anyway.
@akshayasalvi would you be able to submit a follow-up PR to limit the number of digits to 10 in this input please?
francoisl commentedon Sep 14, 2021
Oh haha I just realized the original PR was to cap the amount to 14 digits. I checked that our backend only allows for 10 digits, so 14 wouldn't have worked anyway.
akshayasalvi commentedon Sep 14, 2021
@francoisl Ohh this never came up in any previous discussions XD. Sure I'll add a cap of 10 digits.
botify commentedon Sep 15, 2021
🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀
isagoico commentedon Sep 15, 2021
I think we're good to close this one out CC @francoisl
botify commentedon Sep 15, 2021
🚀 Deployed to staging by @francoisl in version: 1.0.98-2 🚀