[HOLD for payment 2024-11-29] [$250] Track expense - Options are still present in thread details after the expense is deleted

@alexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.63-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+29302390@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to self DM
Track an expense
Go to transaction thread
Send a message
Click on the report header
Click Delete expense
Delete the expense
Click on the thread in the main chat to return to the thread
Click report header

Expected Result:

Track expense options should not be displayed in thread after the expense is deleted

Actual Result:

Track expense options is still displayed in thread after the expense is deleted.
The options lead to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6666489_1731686292257.20241115_235512.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021858671461676585752
Upwork Job ID: 1858671461676585752
Last Price Increase: 2024-11-19
Automatic offers:

ikevin127 | Reviewer | 104973306
twilight2294 | Contributor | 104973308

Issue Owner

Current Issue Owner: @alexpensify

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Options are still present in thread details after the expense is deleted

What is the root cause of that problem?

We do not check if !isDeletedParentAction hence it is shown even when it is deleted

App/src/pages/ReportDetailsPage.tsx

Line 378 in 88713ab

if (isTrackExpenseReport) {

What changes do you think we should make in order to solve the problem?

Add isTrackExpenseReport && !isDeletedParentAction check to fix this

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Options are still present in thread details after the expense is deleted

What is the root cause of that problem?

The track expense option is displayed if a report is a track expense report.

App/src/pages/ReportDetailsPage.tsx

Line 378 in 88713ab

if (isTrackExpenseReport) {

isTrackExpenseReport is true if the parent report action is track expense action and the parent report is the selfDM.

App/src/libs/ReportUtils.ts

Line 1651 in 88713ab

    
           return !isEmptyObject(parentReportAction) && selfDMReportID === report.parentReportID && ReportActionsUtils.isTrackExpenseAction(parentReportAction);

After we delete a track expense, the parent report action still has type as track in originalMessage then the track expense option still appears in the report detail page

What changes do you think we should make in order to solve the problem?

Return false in isTrackExpenseReport function if the parent report action is deleted action

return (
    !isEmptyObject(parentReportAction) &&
    selfDMReportID === report.parentReportID &&
    ReportActionsUtils.isTrackExpenseAction(parentReportAction) &&
    !ReportActionsUtils.isDeletedAction(parentReportAction)
);

App/src/libs/ReportUtils.ts

Line 1651 in 88713ab

    
           return !isEmptyObject(parentReportAction) && selfDMReportID === report.parentReportID && ReportActionsUtils.isTrackExpenseAction(parentReportAction);

Or we can do this in isTrackExpenseAction function

What alternative solutions did you explore? (Optional)

Or after we delete the track expense, we should remove the type in originalMessage of parent report action or change type to the according type.

Job added to Upwork: https://www.upwork.com/jobs/~021858671461676585752

@ikevin127

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@ikevin127

@ikevin127 when you get a chance, please review these proposals and identify whether one will fix the issue. Thank you!

Reviewing label has been removed, please complete the "BugZero Checklist".

@ikevin127

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Track Expense Options are still present in thread details after the expense is deleted #52786

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

@ikevin127 requires payment automatic offer (Reviewer)
@twilight2294 requires payment automatic offer (Contributor)

@ikevin127

@ikevin127 @alexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/51951/files#r1854855831
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Go to self DM > Track an expense.
Go to transaction thread > Send a message.
Click on the report header > Click Delete expense > Delete the expense.
Click on the thread in the main chat to return to the thread > Click report header.
Verify that the Track expense options in the RHP are not displayed anymore after the expense is deleted.

Do we agree 👍 or 👎.

@alexpensify

cc @alexpensify for visibility

@twilight2294

Payouts due: 2024-11-29

Contributor: $250 @twilight2294
Reviewer: $250 @ikevin127

Upwork job is here. The payment process has been completed here via Upwork.

@alexpensify

@alexpensify for payment summaries can you use the below format that makes it clear if an issue's is due or paid (and where they're paid). Thx

Contributor: @ paid $ via Upwork
Contributor+: @ owed $ via NewDot.

@mallenexpensify

@mallenexpensify - I followed up in the B0 Slack room since the template is off in TE, not sure if there are others.

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-29] [$250] Track expense - Options are still present in thread details after the expense is deleted #52628

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

16 remaining items

BugZero Checklist:

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-29] [$250] Track expense - Options are still present in thread details after the expense is deleted #52628

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 15, 2024

twilight2294 commented on Nov 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented on Nov 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Nov 19, 2024

melvin-bot commented on Nov 19, 2024

alexpensify commented on Nov 19, 2024

16 remaining items

melvin-bot commented on Nov 22, 2024

melvin-bot commented on Nov 22, 2024

melvin-bot commented on Nov 22, 2024

ikevin127 commented on Nov 22, 2024

BugZero Checklist:

Regression Test Proposal

ikevin127 commented on Nov 29, 2024

alexpensify commented on Nov 29, 2024

mallenexpensify commented on Dec 2, 2024

alexpensify commented on Dec 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions