[HOLD for payment 2024-11-29] [$250] Group chat - New member is displayed with offline profile avatar

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.63-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5229966&group_by=cases:section_id&group_id=296760&group_order=asc
Email or phone of affected tester (no customers): gocemate+a2862@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Create group conversation with few members
Click on header> Members> Invite new member
Enter email address and take a look at user's avatar

Expected Result:

User should have default or custom profile avatar

Actual Result:

User is displayed with offline profile avatar when invite it in existing group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6666563_1731690502328.Recording__4536.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021858590656610669336
Upwork Job ID: 1858590656610669336
Last Price Increase: 2024-11-18
Automatic offers:

brunovjk | Reviewer | 104980522
gijoe0295 | Contributor | 104980525

Issue Owner

Current Issue Owner: @garrettmknight

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Edited by proposal-police: This proposal was edited at 2024-11-15 18:12:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is displayed with offline profile avatar when invite it in existing group chat

What is the root cause of that problem?

In NewChatPage, we retrieved the personal details data, specifically avatar, from the BE through SearchForReport API.

But in InviteReportParticipantsPage, we only get the details from Onyx.

What changes do you think we should make in order to solve the problem?

In InviteReportParticipantsPage, call SearchForReport same as RoomInvitePage:

App/src/pages/RoomInvitePage.tsx

Lines 238 to 241 in c3c7c7a

    
           useEffect(() => { 
        
               UserSearchPhraseActions.updateUserSearchPhrase(debouncedSearchTerm); 
        
               ReportActions.searchInServer(debouncedSearchTerm); 
        
           }, [debouncedSearchTerm]);

App/src/pages/InviteReportParticipantsPage.tsx

Lines 58 to 60 in c3c7c7a

    
           useEffect(() => { 
        
               UserSearchPhraseActions.updateUserSearchPhrase(debouncedSearchTerm); 
        
           }, [debouncedSearchTerm]);

Report.searchInServer(debouncedSearchTerm);

Job added to Upwork: https://www.upwork.com/jobs/~021858590656610669336

@brunovjk

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

@brunovjk

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: new member shows fallback avatar in report invite page #52844

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

@brunovjk requires payment automatic offer (Reviewer)
@gijoe0295 requires payment automatic offer (Contributor)

@brunovjk

@brunovjk @garrettmknight @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: No PR directly added the bug, there was a detail missed during the implementation of the page.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition: Must be online.

Test:

Go to a group chat
Click on header > Members > Invite new member
Enter an email that hasn't been chatted with but should already exist
Verify his contact not show fallback avatar (it can show fallback avatar briefly while it's fetching data)

Do we agree 👍 or 👎

@deetergp

@deetergp, @garrettmknight, @brunovjk, @gijoe0295 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

All paid out, closing!

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-29] [$250] Group chat - New member is displayed with offline profile avatar #52639

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

22 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition: Must be online.

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	UserSearchPhraseActions.updateUserSearchPhrase(debouncedSearchTerm);
	ReportActions.searchInServer(debouncedSearchTerm);
	}, [debouncedSearchTerm]);

[HOLD for payment 2024-11-29] [$250] Group chat - New member is displayed with offline profile avatar #52639

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 15, 2024

gijoe0295 commented on Nov 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Nov 18, 2024

melvin-bot commented on Nov 18, 2024

22 remaining items

melvin-bot commented on Nov 22, 2024

melvin-bot commented on Nov 22, 2024

brunovjk commented on Nov 28, 2024

BugZero Checklist:

Regression Test Proposal

Precondition: Must be online.

Test:

melvin-bot commented on Dec 2, 2024

garrettmknight commented on Dec 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions