Repository navigation
[HOLD for payment 2024-12-05] [$125] Wallet - No "Make default payment method" option after adding 2nd account #52641
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.63
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #51437
Action Performed:
- Log in to the account that has no bank accounts
- Navigate to Settings > Wallet and click on Add Bank Account > Personal Bank Account
- On the Plaid modal, search and select Wells Fargo bank, enter credentials (e.g., user_good / pass_good), and complete the process
- Verify that the added bank account is not marked as the default (because we are not showing default badge if there is only one bank account)
- Repeat the process to add a second bank account by selecting Chase bank
Expected Result:
The "Make default payment method" option is displayed in the three-dot menu of the first bank account added without needing a page refresh
Actual Result:
The "Make default payment method" option is not displayed in the three-dot menu of the first bank account added after adding 2nd account. A page refresh is needed to display the option
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6666585_1731691611157.51437-mWeb.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021857547420122900843
- Upwork Job ID: 1857547420122900843
- Last Price Increase: 2024-11-15
Issue Owner
Current Issue Owner: @joekaufmanexpensifyMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Nov 15, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.joekaufmanexpensify commentedon Nov 15, 2024
Reproduced
[-]Wallet - No "Make default payment method" option after adding 2nd account[/-][+][$250] Wallet - No "Make default payment method" option after adding 2nd account[/+]melvin-bot commentedon Nov 15, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021857547420122900843
melvin-bot commentedon Nov 15, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)joekaufmanexpensify commentedon Nov 15, 2024
Pretty minor bug, so adjusting price
[-][$250] Wallet - No "Make default payment method" option after adding 2nd account[/-][+][$125] Wallet - No "Make default payment method" option after adding 2nd account[/+]33 remaining items
joekaufmanexpensify commentedon Dec 2, 2024
@thesahindia could you handle checklist so we can prep to pay?
joekaufmanexpensify commentedon Dec 2, 2024
@Shahidullah-Muffakir offer sent for $125!
thesahindia commentedon Dec 4, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
@joekaufmanexpensify, The steps are almost same as https://github.com/Expensify/Expensify/issues/447939, so I have combined them together. Could you please update it with the new steps? It will work for both issues.
Do we agree 👍 or 👎
melvin-bot commentedon Dec 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@joekaufmanexpensify)
joekaufmanexpensify commentedon Dec 6, 2024
Consolidated regression test into https://github.com/Expensify/Expensify/issues/447939
joekaufmanexpensify commentedon Dec 6, 2024
Payment summary above is correct. All set to issue payment!
joekaufmanexpensify commentedon Dec 6, 2024
@Shahidullah-Muffakir $125 sent and contract ended!
joekaufmanexpensify commentedon Dec 6, 2024
Upwork job closed
joekaufmanexpensify commentedon Dec 6, 2024
@thesahindia please request payment in NewDot at your earliest convenience. Closing as this is otherwise all set!
garrettmknight commentedon Dec 21, 2024
$125 approved for @thesahindia