You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-15] [$125] Add "Go to workspace" as a shortcut in all of the workspace chats, rooms and reports details page. #52817
Version Number: v9.0.64-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@trjExpensify Slack conversation: #convert thread
Action Performed:
Create a workspace
Navigate to the #admins room
Click the header of the chat
Expected Result:
This is a new feature
Add a Go to workspace row in the bottom position of the details screen of all workspace chats, rooms, threads originating from a parentChat associated with a workspace, expense reports and expense transaction threads.
When clicked, navigate to the workspace settings page. On small screens that'll be the LHN workspace settings page, on large screens that will be the workspace profile page.
Actual Result:
Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.
Workaround:
N/A, improvement.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Edited by proposal-police: This proposal was edited at 2024-11-20 13:47:59 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.
What is the root cause of that problem?
This is a new feature
What changes do you think we should make in order to solve the problem?
Create a new const here for Go to workspace and a translation key for Go to workspace
Add the Go to workspace item here if the report?.policyID isn't fake policyID with action is a function that we will navigate to the LHN workspace settings page in small screen, navigate to the workspace profile page if it's the large screen.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
But wanted to quickly raise @trjExpensify@youssef-lr. I was wondering if we could keep the regular pay of $250. The change wasn't like a 1-2 liner change as expected. We did some refactor too. This also had a regression so essentially I am request for $125 payout. Let me know what you folks think?
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: New feature
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other: New feature
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Can we treated as a feature request.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Go to any workspace expense chat.
Press report header.
Verify "Go to workspace" menu shows.
Press Go to workspace
Verify app opens workspace initial settings page on small screens and workspace profile page on large screens
Repeat steps 2 - 5 with workspace rooms, workspace's expense reports, workspace's transaction thread reports, thread reports originating from any kind of workspace chats listed above
Enable the invoices feature
Create a send invoice
Delete the workspace
Go the report detail of the invoice report and verify that no Leave option
Open the report detail of the workspace chat and verify that no Go to workspace option
Activity
melvin-bot commentedon Nov 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon Nov 20, 2024
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.
mkzie2 commentedon Nov 20, 2024
Edited by proposal-police: This proposal was edited at 2024-11-20 13:47:59 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.
What is the root cause of that problem?
This is a new feature
What changes do you think we should make in order to solve the problem?
Create a new const here for
Go to workspaceand a translation key forGo to workspaceAdd the
Go to workspaceitem here if thereport?.policyIDisn't fake policyID withactionis a function that we will navigate to the LHN workspace settings page in small screen, navigate to the workspace profile page if it's the large screen.App/src/pages/ReportDetailsPage.tsx
Line 520 in 9f83a41
What alternative solutions did you explore? (Optional)
74 remaining items
melvin-bot commentedon Jan 8, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 8, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Jan 15, 2025
👋 checklist time here!
mananjadhav commentedon Jan 15, 2025
Yes. I'll work through this.
But wanted to quickly raise @trjExpensify @youssef-lr. I was wondering if we could keep the regular pay of $250. The change wasn't like a 1-2 liner change as expected. We did some refactor too. This also had a regression so essentially I am request for $125 payout. Let me know what you folks think?
youssef-lr commentedon Jan 15, 2025
I'm cool with that @mananjadhav
trjExpensify commentedon Jan 15, 2025
Sounds good!
mananjadhav commentedon Jan 15, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Can we treated as a feature request.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
LeaveoptionGo to workspaceoptionDo we agree 👍 or 👎
@trjExpensify This is ready for payout.
trjExpensify commentedon Jan 15, 2025
Payment summary as follows:
Regression test issue created here. Closing, thanks!
garrettmknight commentedon Jan 21, 2025
$125 approved for @mananjadhav