Skip to content

[HOLD for payment 2025-01-15] [$125] Add "Go to workspace" as a shortcut in all of the workspace chats, rooms and reports details page.  #52817

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.64-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: #convert thread

Action Performed:

  1. Create a workspace
  2. Navigate to the #admins room
  3. Click the header of the chat

Expected Result:

This is a new feature

  1. Add a Go to workspace row in the bottom position of the details screen of all workspace chats, rooms, threads originating from a parentChat associated with a workspace, expense reports and expense transaction threads.
image
  1. When clicked, navigate to the workspace settings page. On small screens that'll be the LHN workspace settings page, on large screens that will be the workspace profile page.

Actual Result:

Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.

Workaround:

N/A, improvement.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021860062325064165317
  • Upwork Job ID: 1860062325064165317
  • Last Price Increase: 2024-11-22
  • Automatic offers:
    • mkzie2 | Contributor | 105028511
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on Nov 20, 2024
  2. self-assigned this
    on Nov 20, 2024
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 20, 2024
  4. melvin-bot commented on Nov 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  5. melvin-bot commented on Nov 20, 2024

    @melvin-bot

    Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  6. mkzie2 commented on Nov 20, 2024

    @mkzie2
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-11-20 13:47:59 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.

    What is the root cause of that problem?

    This is a new feature

    What changes do you think we should make in order to solve the problem?

    1. Create a new const here for Go to workspace and a translation key for Go to workspace

    2. Add the Go to workspace item here if the report?.policyID isn't fake policyID with action is a function that we will navigate to the LHN workspace settings page in small screen, navigate to the workspace profile page if it's the large screen.

    if (report?.policyID && report?.policyID !== CONST.POLICY.ID_FAKE) {
        items.push({
            key: CONST.REPORT_DETAILS_MENU_ITEM.GO_TO_WORKSPACE,
            translationKey: 'common.goToWorkspace',
            icon: Expensicons.Workspace,
            action: () => {
                if (isSmallScreenWidth) {
                    Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID));
                    return;
                }
                Navigation.navigate(ROUTES.WORKSPACE_PROFILE.getRoute(report?.policyID));
            },
            isAnonymousAction: false,
            shouldShowRightIcon: true,
        })
    }
    

    What alternative solutions did you explore? (Optional)

  7. 74 remaining items

  8. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-15. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  10. trjExpensify commented on Jan 15, 2025

    @trjExpensify
    ContributorAuthor

    👋 checklist time here!

  11. mananjadhav commented on Jan 15, 2025

    @mananjadhav
    Collaborator

    Yes. I'll work through this.

    But wanted to quickly raise @trjExpensify @youssef-lr. I was wondering if we could keep the regular pay of $250. The change wasn't like a 1-2 liner change as expected. We did some refactor too. This also had a regression so essentially I am request for $125 payout. Let me know what you folks think?

  12. youssef-lr commented on Jan 15, 2025

    @youssef-lr
    Contributor

    I'm cool with that @mananjadhav

  13. trjExpensify commented on Jan 15, 2025

    @trjExpensify
    ContributorAuthor

    Sounds good!

  14. mananjadhav commented on Jan 15, 2025

    @mananjadhav
    Collaborator

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: New feature

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other: New feature

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Can we treated as a feature request.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    1. Go to any workspace expense chat.
    2. Press report header.
    3. Verify "Go to workspace" menu shows.
    4. Press Go to workspace
    5. Verify app opens workspace initial settings page on small screens and workspace profile page on large screens
    6. Repeat steps 2 - 5 with workspace rooms, workspace's expense reports, workspace's transaction thread reports, thread reports originating from any kind of workspace chats listed above
    7. Enable the invoices feature
    8. Create a send invoice
    9. Delete the workspace
    10. Go the report detail of the invoice report and verify that no Leave option
    11. Open the report detail of the workspace chat and verify that no Go to workspace option

    Do we agree 👍 or 👎

    @trjExpensify This is ready for payout.

  15. trjExpensify commented on Jan 15, 2025

    @trjExpensify
    ContributorAuthor

    Payment summary as follows:

    • $125 to @mananjadhav for the C+ review (go ahead and request!)
    • $125 to @mkzie2 for the fix (paid!

    Regression test issue created here. Closing, thanks!

  16. garrettmknight commented on Jan 21, 2025

    @garrettmknight
    Contributor

    $125 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions