[HOLD for payment 2024-12-20] [$250] iOS - Report - Conversation does not scroll down after deleting an attachment

@Pujan92

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5241542
Issue reported by: Applause - Internal Team

Action Performed:

Open New Expensify app Hybrid
Go to the conversation with the history of the message
Send an image to the conversation
Delete the sent image

Expected Result:

The conversation should scroll down after deleting the attachment

Actual Result:

Conversation does not scroll down after deleting an attachment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6671321_1732146742667.ScreenRecording_11-21-2024_04-47-49_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859628438339074230
Upwork Job ID: 1859628438339074230
Last Price Increase: 2024-12-05

Issue Owner

Current Issue Owner: @Pujan92

@puneetlath

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The chat doesn't scroll after deleting an attachment.

What is the root cause of that problem?

This happens because hasNewestReportAction is false.

App/src/pages/home/report/ReportActionsView.tsx

Line 471 in c18812a

    
           const shouldEnableAutoScroll = (hasNewestReportAction && (!reportActionID || !isNavigatingToLinkedMessage)) || (transactionThreadReport && !prevTransactionThreadReport);

hasNewestReportAction compares the last action created with the report lastVisibleActionCreated.

App/src/pages/home/report/ReportActionsView.tsx

Line 288 in c18812a

    
           const hasNewestReportAction = reportActions.at(0)?.created === report.lastVisibleActionCreated || reportActions.at(0)?.created === transactionThreadReport?.lastVisibleActionCreated;

When we delete the attachment, lastVisibleActionCreated is updated to the previous action created. However, the last action is still the deleted attachment.

What changes do you think we should make in order to solve the problem?

Currently, we have 2 places of hasNewestReportAction logic. If we look at the one in ReportActionsList, we can see that the report actions are filtered, so only visible actions will be considered the last action.

App/src/pages/home/report/ReportActionsList.tsx

Lines 185 to 197 in c18812a

    
           const sortedVisibleReportActions = useMemo( 
        
               () => 
        
                   sortedReportActions.filter( 
        
                       (reportAction) => 
        
                           (isOffline || 
        
                               ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
                               reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
                               reportAction.errors) && 
        
                           ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, ReportUtils.canUserPerformWriteAction(report)), 
        
                   ), 
        
               [sortedReportActions, isOffline, report], 
        
           ); 
        
           const lastAction = sortedVisibleReportActions.at(0);

App/src/pages/home/report/ReportActionsList.tsx

Line 360 in c18812a

const hasNewestReportAction = lastAction?.created === lastVisibleActionCreated;

So, the hasNewestReportAction in ReportActionList works correctly, but not in ReportActionsView. To fix this, we need to filter out the actions in ReportActionsView too. We can move the filtered actions from ReportActionsList

App/src/pages/home/report/ReportActionsList.tsx

Lines 185 to 197 in c18812a

    
           const sortedVisibleReportActions = useMemo( 
        
               () => 
        
                   sortedReportActions.filter( 
        
                       (reportAction) => 
        
                           (isOffline || 
        
                               ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
                               reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
                               reportAction.errors) && 
        
                           ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, ReportUtils.canUserPerformWriteAction(report)), 
        
                   ), 
        
               [sortedReportActions, isOffline, report], 
        
           ); 
        
           const lastAction = sortedVisibleReportActions.at(0);

to ReportActionsView. Then, use it for hasNewestReportAction.

App/src/pages/home/report/ReportActionsView.tsx

Line 288 in c18812a

    
           const hasNewestReportAction = reportActions.at(0)?.created === report.lastVisibleActionCreated || reportActions.at(0)?.created === transactionThreadReport?.lastVisibleActionCreated;

const visibleReportActions = useMemo(
    () => reportActions.filter(...),
    [reportActions, isOffline],
);

const hasNewestReportAction = visibleReportActions.at(0)?.created === report.lastVisibleActionCreated || visibleReportActions.at(0)?.created === transactionThreadReport?.lastVisibleActionCreated;

Then, pass the filtered actions to ReportActionsList.

<ReportActionsList
    sortedVisibleReportActions={visibleReportActions}

we can consider moving the hasNewestReportAction from ReportActionsList to ReportActionsView too, so we only have 1 logic for it

Job added to Upwork: https://www.upwork.com/jobs/~021859628438339074230

@Pujan92

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@puneetlath

@puneetlath we can close this issue due to a similar issue has been created earlier and @bernhardoj can transfer their proposal there.

Based on the proposal there, looks like the root cause and solution is different.

RCA of both issues looks similar to me where the issue remains in deriving the hasNewestReportAction due to the different values of last report action created and report lastVisibleActionCreated.

Yes, both issues are because of the wrong value of hasNewestReportAction, but the root cause and solution are still different. I tested my solution and the other issue still persists, so I can't transfer my proposal there because it won't fix that issue.

@Pujan92

@Pujan92 @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@joekaufmanexpensify

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@Pujan92

Payment Summary

Upwork Job

Reviewer: @Pujan92 owed $250 via NewDot
Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@joekaufmanexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1859628438339074230/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Asked in slack so we can get checklist done today.

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/30269/files#r1894124542
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/455241

Regression Test Proposal

Send an attachment to any chat
Delete the attachment
Verify the chat is scrolled to the bottom

Do we agree 👍 or 👎

TY! I shared the regression test issue above, so checklist is all set.

@bernhardoj

Good to issue payment. We need to pay:

@bernhardoj - $250 for PR via NewDot.
@Pujan92 - $250 for C+ via NewDot.

@Pujan92

@Pujan92 / @bernhardoj please request payment at your earliest convenience. Closing as this is otherwise all set!

Requested in ND.

@Pujan92

$250 approved for @Pujan92

@bernhardoj

$250 approved for @bernhardoj

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-20] [$250] iOS - Report - Conversation does not scroll down after deleting an attachment #52861

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

32 remaining items

Payment Summary

BugZero Checklist (@joekaufmanexpensify)

BugZero Checklist:

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const sortedVisibleReportActions = useMemo(
	() =>
	sortedReportActions.filter(
	(reportAction) =>
	(isOffline \|\|
	ReportActionsUtils.isDeletedParentAction(reportAction) \|\|
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE \|\|
	reportAction.errors) &&
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, ReportUtils.canUserPerformWriteAction(report)),
	),
	[sortedReportActions, isOffline, report],
	);
	const lastAction = sortedVisibleReportActions.at(0);

[HOLD for payment 2024-12-20] [$250] iOS - Report - Conversation does not scroll down after deleting an attachment #52861

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 21, 2024

bernhardoj commented on Nov 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Nov 21, 2024

melvin-bot commented on Nov 21, 2024

Pujan92 commented on Nov 22, 2024

bernhardoj commented on Nov 22, 2024

Pujan92 commented on Nov 22, 2024

bernhardoj commented on Nov 22, 2024

32 remaining items

melvin-bot commented on Dec 13, 2024

melvin-bot commented on Dec 20, 2024

melvin-bot commented on Dec 20, 2024

Payment Summary

BugZero Checklist (@joekaufmanexpensify)

joekaufmanexpensify commented on Dec 20, 2024

Pujan92 commented on Dec 20, 2024

BugZero Checklist:

Regression Test Proposal

joekaufmanexpensify commented on Dec 20, 2024

joekaufmanexpensify commented on Dec 20, 2024

joekaufmanexpensify commented on Dec 20, 2024

bernhardoj commented on Dec 21, 2024

garrettmknight commented on Dec 21, 2024

JmillsExpensify commented on Dec 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions