[HOLD for payment 2024-12-03] [HOLD for payment 2024-11-29] Search - Website crashes after exploring expenses in search for some time

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Open the staging.new.expensify.com website.
Log in with an account with several expenses on it.
Tap on search on the bottom of the page.
Open any expense.
Tap on the arrow on the top left corner.
Open a different expense.
Tap on the arrow on the top left corner.
Repeat steps 4 - 5 a few more times.
Verify that the user can continue exploring all the expenses without the website crashing.

Expected Result:

The user should be able to explore expenses in search without the website crashing.

Actual Result:

The website crashes after opening and closing expenses for some time in search section.
Error Message - "Uh oh, something went wrong."

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6671401_1732156471509.Crash_Search.1.mp4

2111_1.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @CortneyOfstad

@MonilBhavsar

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The website crashes after opening and closing expenses for some time in search section.
Error Message - "Uh oh, something went wrong."

What is the root cause of that problem?

We pass the reportID as report?.reportID, which can be empty string here

App/src/pages/home/ReportScreen.tsx

Line 172 in 376f9f0

reportID: reportOnyx.reportID ?? '',

App/src/pages/home/ReportScreen.tsx

Line 224 in 376f9f0

    
           const {reportActions, linkedAction, sortedAllReportActions, hasNewerActions, hasOlderActions} = usePaginatedReportActions(reportID, reportActionIDFromRoute);

Then the app crashes when we use useOnyx here, the key changes from report_id to report_

App/src/hooks/usePaginatedReportActions.ts

Line 15 in 376f9f0

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

What changes do you think we should make in order to solve the problem?

Fallback reportID to -1 here

App/src/pages/home/ReportScreen.tsx

Line 172 in 376f9f0

reportID: reportOnyx.reportID ?? '',

Or we can use reportIDFromRoute instead

App/src/pages/home/ReportScreen.tsx

Line 224 in 376f9f0

    
           const {reportActions, linkedAction, sortedAllReportActions, hasNewerActions, hasOlderActions} = usePaginatedReportActions(reportID, reportActionIDFromRoute);

Or we can add fallback -1 here

 const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID || '-1'}`);

App/src/hooks/usePaginatedReportActions.ts

Line 15 in 376f9f0

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

What alternative solutions did you explore? (Optional)

@MonilBhavsar

@MonilBhavsar I can raise a quick fix if needed.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rayane-djouah

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] fix: Search - Website crashes after exploring expenses in search for some time. #52888

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

@rayane-djouah requires payment (Needs manual offer from BZ)

@rayane-djouah

@rayane-djouah @CortneyOfstad @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@rayane-djouah

@rayane-djouah — sent you an offer in Upwork here. Please accept and complete the check list at your earliest convenience — thanks!

@CortneyOfstad

@CortneyOfstad - No payment is needed for me

BugZero Checklist:

Classify the bug:
Bug classification

Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production
- 2b. Reported on staging (deploy blocker)
- 2c. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/50692/files#r1863577990
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1732889804245739
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A

@CortneyOfstad

@CortneyOfstad, @MonilBhavsar, @mountiny, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

No payment is needed. We can close this one.

@rayane-djouah

Payment Summary

Upwork Job

ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@CortneyOfstad)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Thank you all! 🙇

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-03] [HOLD for payment 2024-11-29] Search - Website crashes after exploring expenses in search for some time #52864

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

BugZero Checklist:

Payment Summary

BugZero Checklist (@CortneyOfstad)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-12-03] [HOLD for payment 2024-11-29] Search - Website crashes after exploring expenses in search for some time #52864

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 21, 2024

melvin-bot commented on Nov 21, 2024

melvin-bot commented on Nov 21, 2024

github-actions commented on Nov 21, 2024

mkzie2 commented on Nov 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mkzie2 commented on Nov 21, 2024

melvin-bot commented on Nov 21, 2024

23 remaining items

melvin-bot commented on Nov 26, 2024

melvin-bot commented on Nov 26, 2024

CortneyOfstad commented on Nov 26, 2024

rayane-d commented on Nov 29, 2024

rayane-d commented on Nov 29, 2024

BugZero Checklist:

melvin-bot commented on Dec 2, 2024

rayane-d commented on Dec 2, 2024

melvin-bot commented on Dec 3, 2024

Payment Summary

BugZero Checklist (@CortneyOfstad)

MonilBhavsar commented on Dec 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions