[HOLD for payment 2024-12-03] [Company cards] Navigate to some other existing feed after removing one

@bfitzexpensify

Coming from here

When user has 2 or more company card feeds and we remove one of them, make sure to navigate them and show them some other feed right after the removal. No particular order, just take the first one in the domain_member object

Issue Owner

Current Issue Owner: @bfitzexpensify

@OfstadC

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

No need for b0

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@bfitzexpensify

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@VickyStash

Payment Summary

Upwork Job

Contributor: @VickyStash is from an agency-contributor and not due payment
ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: https://expensify.slack.com/archives/C06ML6X0W9L/p1732116549221049?thread_ts=1732108983.281759&cid=C06ML6X0W9L
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Create a workspace.
Enable Company cards feature.
Add at least two feeds to the workspace.
Open one of the created feeds. Go to Settings and Remove it. Make sure another feed will be opened for you.
Remove the second feed as well. Make sure you see the no feed view.

Do we agree 👍 or 👎

@DylanDylann

@DylanDylann can you please add comments or link prs in all the checklist sections?

@mountiny

@mountiny

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

About this point, this is not a bug, when implementing this feature we already missed from the design doc

Ok, nice feel free to leave such quick note in the checklist in future

@bfitzexpensify

@bfitzexpensify lets please add this regression test

@DylanDylann

Regression steps proposed. @DylanDylann offer sent for payment.

No need payment here. Let's close this issue

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-03] [Company cards] Navigate to some other existing feed after removing one #52886

14 remaining items

Payment Summary

BugZero Checklist (@bfitzexpensify)

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-12-03] [Company cards] Navigate to some other existing feed after removing one #52886

Description

Activity

melvin-bot commented on Nov 21, 2024

mountiny commented on Nov 21, 2024

VickyStash commented on Nov 21, 2024

14 remaining items

melvin-bot commented on Dec 3, 2024

melvin-bot commented on Dec 3, 2024

Payment Summary

BugZero Checklist (@bfitzexpensify)

DylanDylann commented on Dec 3, 2024

BugZero Checklist:

Regression Test Proposal

Test:

mountiny commented on Dec 3, 2024

DylanDylann commented on Dec 3, 2024

mountiny commented on Dec 3, 2024

mountiny commented on Dec 3, 2024

bfitzexpensify commented on Dec 3, 2024

DylanDylann commented on Dec 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions