Skip to content

[$250] Track expense-In self DM, create expense is shown instead track expense #52897

New issue
New issue
Closed
Closed
[$250] Track expense-In self DM, create expense is shown instead track expense#52897
Assignees
abekkalagrgiaahmedGaber93
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@IuliiaHerets
IuliiaHerets
opened on Nov 21, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.65-1
Reproducible in staging?: Y
Reproducible in production?: Y
Isuue was found when executing this PR: #52786
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Login with new gmail account
  3. Open self DM
  4. Tap plus icon next to chat input

Expected Result:

In self DM, track expense must be shown .

Actual Result:

In self DM, create expense is shown instead track expense.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6671460_1732161962885.Screenrecorder-2024-11-21-09-31-54-5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861530490609565618
  • Upwork Job ID: 1861530490609565618
  • Last Price Increase: 2024-12-10
Issue OwnerCurrent Issue Owner: @ahmedGaber93

Activity

  1. IuliiaHerets
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 21, 2024
  2. melvin-bot
    assigned
    abekkala
    on Nov 21, 2024

  3. melvin-bot commented on Nov 21, 2024

    @melvin-bot
    melvin-botBot
    on Nov 21, 2024 – with Melvin Bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. mkzie2 commented on Nov 21, 2024

    @mkzie2
    mkzie2
    on Nov 21, 2024
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-11-21 13:15:52 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    In self DM, create expense is shown instead track expense.

    What is the root cause of that problem?

    We display Create expense if canUseCombinedTrackSubmit is true.

    App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

    Lines 162 to 163 in 4617816

    icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
    text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

    What changes do you think we should make in order to solve the problem?

    I think we should display Track expense for all case in the plus icon of SelfDM

    icon:  getIconForAction(CONST.IOU.TYPE.TRACK),
text: translate('iou.trackExpense'),

    App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

    Lines 162 to 163 in 4617816

    icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
    text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

    OPTIONAL: We can also change this to always display Track expense

    App/src/pages/iou/request/IOURequestStartPage.tsx

    Line 58 in 4617816

    [CONST.IOU.TYPE.TRACK]: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

    What alternative solutions did you explore? (Optional)

    NA

  5. melvin-bot
    added
    Overdue
    on Nov 25, 2024

  6. melvin-bot commented on Nov 25, 2024

    @melvin-bot
    melvin-botBot
    on Nov 25, 2024 – with Melvin Bot

    @abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. abekkala commented on Nov 26, 2024

    @abekkala
    abekkala
    on Nov 26, 2024
    Contributor

    confirmed in slack that it should be track

  8. melvin-bot
    removed
    Overdue
    on Nov 26, 2024
  9. abekkala
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    Overdue
    on Nov 26, 2024

  10. melvin-bot commented on Nov 26, 2024

    @melvin-bot
    melvin-botBot
    on Nov 26, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021861530490609565618

  11. melvin-bot
    changed the title [-]Track expense-In self DM, create expense is shown instead track expense[/-] [+][$250] Track expense-In self DM, create expense is shown instead track expense[/+] on Nov 26, 2024
  12. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 26, 2024

  13. melvin-bot commented on Nov 26, 2024

    @melvin-bot
    melvin-botBot
    on Nov 26, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

  14. 13 remaining items

  15. melvin-bot
    added
    Overdue
    on Dec 5, 2024

  16. ahmedGaber93 commented on Dec 5, 2024

    @ahmedGaber93
    ahmedGaber93
    on Dec 5, 2024
    Contributor

    @abekkala bump #52897 (comment)

  17. melvin-bot
    removed
    Overdue
    on Dec 5, 2024

  18. abekkala commented on Dec 6, 2024

    @abekkala
    abekkala
    on Dec 6, 2024
    Contributor

    @grgia since you're familiar with this can you confirm #52897 (comment)

  19. mvtglobally commented on Dec 7, 2024

    @mvtglobally
    mvtglobally
    on Dec 7, 2024

    Issue not reproducible during KI retests. (First week)

  20. melvin-bot commented on Dec 10, 2024

    @melvin-bot
    melvin-botBot
    on Dec 10, 2024 – with Melvin Bot

    @abekkala, @ahmedGaber93 Eep! 4 days overdue now. Issues have feelings too...

  21. melvin-bot
    added
    Overdue
    on Dec 10, 2024

  22. ahmedGaber93 commented on Dec 10, 2024

    @ahmedGaber93
    ahmedGaber93
    on Dec 10, 2024
    Contributor

    WDYT @grgia ^?

  23. melvin-bot
    removed
    Overdue
    on Dec 10, 2024

  24. melvin-bot commented on Dec 10, 2024

    @melvin-bot
    melvin-botBot
    on Dec 10, 2024 – with Melvin Bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  25. ahmedGaber93 commented on Dec 11, 2024

    @ahmedGaber93
    ahmedGaber93
    on Dec 11, 2024
    Contributor

    Bumped @grgia on slack

  26. grgia
    self-assigned this
    on Dec 12, 2024

  27. grgia commented on Dec 12, 2024

    @grgia
    grgia
    on Dec 12, 2024
    Contributor

    Closing for #53656

  28. grgia
    closed this as completedon Dec 12, 2024
  29. github-project-automation
    moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions