[HOLD for payment 2024-12-20] [$250] Wrong page when navigating back from access level page

@DylanDylann

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.64-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

Go To Security Page
Add Copilot
Click on any user
Click on "FULL" access
Click on access level row
Click back button

Expected Result:

The App navigate to confirmation page

Actual Result:

The App navigate to the user selection page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-11-21.at.17.31.08.mov

Recording.775.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859633840404147585
Upwork Job ID: 1859633840404147585
Last Price Increase: 2024-11-28
Automatic offers:

DylanDylann | Contributor | 105191983

Issue Owner

Current Issue Owner: @DylanDylann

@puneetlath

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Right here we go back to add delegate page instead of going back or passing the back to param

App/src/pages/settings/Security/AddDelegate/SelectDelegateRolePage.tsx

Lines 37 to 39 in 4c44827

    
           <HeaderWithBackButton 
        
               title={translate('delegate.accessLevel')} 
        
               onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_ADD_DELEGATE)}

What changes do you think we should make in order to solve the problem?

We can just invoke the goBack without passing any fallback route

onBackButtonPress={() => Navigation.goBack()}

Or we can pass the backTo param as the fallback route

We can do the same approach for other pages if needed

What alternative solutions did you explore? (Optional)

Edited by proposal-police: This proposal was edited at 2024-11-21 13:46:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong page when navigating back from access level page

What is the root cause of that problem?

While we are on the role page by selecting the role at the confirmation page and navigate here

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Line 73 in 00a81dc

    
           onPress={() => Navigation.navigate(ROUTES.SETTINGS_DELEGATE_ROLE.getRoute(login, role))}

nav stack: [user page, role page]

Then we click to back button, it will navigate to the user selection page here.

App/src/pages/settings/Security/AddDelegate/SelectDelegateRolePage.tsx

Line 39 in 00a81dc

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_ADD_DELEGATE)}

Because we use NAVIGATE, it will go back to the page that is already in the stack.

What changes do you think we should make in order to solve the problem?

We should do the same way we did with approver flow here, here.

Add type PUSH to this navigation

    onPress={() => Navigation.navigate(ROUTES.SETTINGS_DELEGATE_ROLE.getRoute(login, role), CONST.NAVIGATION.ACTION_TYPE.PUSH)}

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Line 54 in 00a81dc

    
           onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_DELEGATE_ROLE.getRoute(login, role))}

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021859633840404147585

@eVoloshchak

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@puneetlath

@puneetlath, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@eVoloshchak

@eVoloshchak thoughts on the proposals?

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Wrong page when navigating back from access level page #53811

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment automatic offer (Contributor)
@nkdengineer requires payment (Needs manual offer from BZ)
@DylanDylann requires payment automatic offer (Contributor)

@DylanDylann

@DylanDylann @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@abekkala

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@DylanDylann

@DylanDylann please complete checklist and I can process payments due today. thanks!

@nkdengineer

PAYMENT SUMMARY FOR DEC 20

Fix: @nkdengineer [$250] OFFER
PR Review: @DylanDylann [$250] Offer

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Add copilot section to security page and add copilot #47353 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/455639

Regression Test Proposal

Test:

Go To the Security Page
Add Copilot
Click on any user
Click on "FULL" access
Click on the access level row
Click back button
Verify that: The App navigates to the confirmation page

Do we agree 👍 or 👎

@DylanDylann

@DylanDylann @nkdengineer payments sent and contracts ended - thank you! 🎉

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-20] [$250] Wrong page when navigating back from access level page #52904

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

29 remaining items

PAYMENT SUMMARY FOR DEC 20

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<HeaderWithBackButton
	title={translate('delegate.accessLevel')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_ADD_DELEGATE)}

[HOLD for payment 2024-12-20] [$250] Wrong page when navigating back from access level page #52904

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 21, 2024

NJ-2020 commented on Nov 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented on Nov 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Nov 21, 2024

melvin-bot commented on Nov 21, 2024

melvin-bot commented on Nov 25, 2024

puneetlath commented on Nov 25, 2024

29 remaining items

melvin-bot commented on Dec 13, 2024

melvin-bot commented on Dec 13, 2024

melvin-bot commented on Dec 20, 2024

abekkala commented on Dec 20, 2024

abekkala commented on Dec 20, 2024

PAYMENT SUMMARY FOR DEC 20

DylanDylann commented on Dec 20, 2024

BugZero Checklist:

Regression Test Proposal

Test:

abekkala commented on Dec 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions