Skip to content

[HOLD for payment 2024-12-03] [HOLD FOR #52893] [Company Cards] Card number is not visible in the cards table  #52915

Closed

Description

@mountiny

Coming from here

When connecting a direct feed connection, we are missing the last 4 pan number in the company cards feed table.

image

Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 21, 2024
  2. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. moved this to Bugs and Follow Up Issues in #expensify-bugson Nov 21, 2024
  4. VickyStash commented on Nov 21, 2024

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  5. VickyStash commented on Nov 21, 2024

    @VickyStash
    Contributor

    The issue will be fixed in this PR: #52893 (comment)

  6. 6 remaining items

  7. changed the title [-][HOLD FOR #52893] [Company Cards] Card number is not visible in the cards table [/-] [+][HOLD for payment 2024-12-03] [HOLD FOR #52893] [Company Cards] Card number is not visible in the cards table [/+] on Nov 26, 2024
  8. melvin-bot commented on Nov 26, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Nov 26, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-03. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Nov 26, 2024

    @melvin-bot

    @mountiny @isabelastisser @VickyStash The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Dec 3, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  12. mountiny commented on Dec 3, 2024

    @mountiny
    ContributorAuthor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: the author of the PR addressed this issue

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: No need for regression test

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  13. mountiny commented on Dec 3, 2024

    @mountiny
    ContributorAuthor

    Noone to pay here now and no need for regression testing

  14. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions