You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser #52918
Version Number: 9.0.65-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Preconditions: Account is created and user is logged in both in app and mWeb
When changed in other platform, the currentSkinTone.skinTone got changed to the one selected on other platform, but the highlightedIndex is still the previous one that selected on this platform
What changes do you think we should make in order to solve the problem?
changed the title [-]Chat - Two emoji skin tones are displayed after changing tone in browser[/-][+][$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+]on Dec 2, 2024
changed the title [-][$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/-][+][HOLD for payment 2024-12-19] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+]on Dec 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rayane-djouah@strepanier03@rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[@strepanier03] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
#### Precondition:
- N/A
#### Test:
1. Go to any chat and select emoji picker
2. Change the skin tone that is currently selected
3. Open another platform version (e.g. mWeb version)
4. Go to the same chat as in step 1
5. Select a different skin tone on the other platform (from step 4)
6. Navigate back to the original platform and open the emoji picker
7. Verify that the selected emoji skin tone is set to only one, not two
changed the title [-][HOLD for payment 2024-12-19] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/-][+][PAID] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+]on Dec 19, 2024
Activity
melvin-bot commentedon Nov 21, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Nov 21, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Two emoji skin tones are displayed after changing tone in browser
What is the root cause of that problem?
We highlight if equals to
highlightedIndexorcurrentSkinTone.skinToneApp/src/components/EmojiPicker/EmojiSkinToneList.tsx
Line 69 in 3611198
On updateSelectedSkinTone we set the highlighted Index
App/src/components/EmojiPicker/EmojiSkinToneList.tsx
Lines 31 to 34 in 3611198
When changed in other platform, the
currentSkinTone.skinTonegot changed to the one selected on other platform, but thehighlightedIndexis still the previous one that selected on this platformWhat changes do you think we should make in order to solve the problem?
Remove this code
App/src/components/EmojiPicker/EmojiSkinToneList.tsx
Line 32 in 3611198
What alternative solutions did you explore? (Optional)
Or set the highlightedIndex with the new currentSkinTone.skinTone
melvin-bot commentedon Nov 25, 2024
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Nov 27, 2024
@strepanier03 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Nov 29, 2024
@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
[-]Chat - Two emoji skin tones are displayed after changing tone in browser[/-][+][$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+]melvin-bot commentedon Dec 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021863719314516934466
melvin-bot commentedon Dec 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (
External)25 remaining items
[-][$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/-][+][HOLD for payment 2024-12-19] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+]melvin-bot commentedon Dec 12, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 12, 2024
@rayane-djouah @strepanier03 @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rayane-d commentedon Dec 13, 2024
BugZero Checklist:
Classify the bug:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/12860/files#r1883724802
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[@strepanier03] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/454938
Regression Test Proposal
Do we agree 👍 or 👎
strepanier03 commentedon Dec 19, 2024
Payment Summary
strepanier03 commentedon Dec 19, 2024
I've paid and closed both contracts, plus I've made the reg test GH. Closing this out.
[-][HOLD for payment 2024-12-19] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/-][+][PAID] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+]