Skip to content

[PAID] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser #52918

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.65-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions: Account is created and user is logged in both in app and mWeb

  1. Open New Expensify app
  2. Go to any chat and select emoji picker
  3. Change the skin tone
  4. Change the skin tone that is currently selected
  5. Open mWeb https://staging.new.expensify.com/
  6. Go to the chat as in step 2
  7. Select a different skin tone in the mWeb
  8. Navigate to android app and select emoji picker

Expected Result:

The last skin tone should be selected

Actual Result:

Two skin tones are displayed in the mobile app: the original selection from the app and the updated selection from the browser

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6661609_1731344323925.recording_20241111_175747.mp4

06-343

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863719314516934466
  • Upwork Job ID: 1863719314516934466
  • Last Price Increase: 2024-12-02
  • Automatic offers:
    • rayane-djouah | Reviewer | 105228437
    • nyomanjyotisa | Contributor | 105228439
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 21, 2024
  2. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Nov 21, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat - Two emoji skin tones are displayed after changing tone in browser

    What is the root cause of that problem?

    We highlight if equals to highlightedIndex or currentSkinTone.skinTone

    isHighlighted={skinToneEmoji.skinTone === highlightedIndex || skinToneEmoji.skinTone === currentSkinTone.skinTone}

    On updateSelectedSkinTone we set the highlighted Index

    function updateSelectedSkinTone(skinToneEmoji: SkinToneEmoji) {
    setHighlightedIndex(skinToneEmoji.skinTone);
    setPreferredSkinTone(skinToneEmoji.skinTone);
    }

    When changed in other platform, the currentSkinTone.skinTone got changed to the one selected on other platform, but the highlightedIndex is still the previous one that selected on this platform

    What changes do you think we should make in order to solve the problem?

    Remove this code

    setHighlightedIndex(skinToneEmoji.skinTone);

    What alternative solutions did you explore? (Optional)

    Or set the highlightedIndex with the new currentSkinTone.skinTone

        useEffect(() => {
            setHighlightedIndex(currentSkinTone.skinTone);
        }, [currentSkinTone]);
    
  4. melvin-bot commented on Nov 25, 2024

    @melvin-bot

    @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. melvin-bot commented on Nov 27, 2024

    @melvin-bot

    @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

  6. melvin-bot commented on Nov 29, 2024

    @melvin-bot

    @strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 2, 2024
  8. changed the title [-]Chat - Two emoji skin tones are displayed after changing tone in browser[/-] [+][$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+] on Dec 2, 2024
  9. melvin-bot commented on Dec 2, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 2, 2024
  11. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

  12. 25 remaining items

  13. changed the title [-][$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/-] [+][HOLD for payment 2024-12-19] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+] on Dec 12, 2024
  14. melvin-bot commented on Dec 12, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Dec 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-19. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Dec 12, 2024

    @melvin-bot

    @rayane-djouah @strepanier03 @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. rayane-d commented on Dec 13, 2024

    @rayane-d
    Contributor

    BugZero Checklist:

    • Classify the bug:

      Bug classification

      Source of bug:

      • 1a. Result of the original design (eg. a case wasn't considered)
      • 1b. Mistake during implementation
      • 1c. Backend bug
      • 1z. Other:

      Where bug was reported:

      • 2a. Reported on production
      • 2b. Reported on staging (deploy blocker)
      • 2c. Reported on a PR
      • 2z. Other:

      Who reported the bug:

      • 3a. Expensify user
      • 3b. Expensify employee
      • 3c. Contributor
      • 3d. QA
      • 3z. Other:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/12860/files#r1883724802

    • If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [@strepanier03] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/454938

    Regression Test Proposal

    #### Precondition:
    
    - N/A
    
    #### Test:
    
    1. Go to any chat and select emoji picker
    2. Change the skin tone that is currently selected
    3. Open another platform version (e.g. mWeb version)
    4. Go to the same chat as in step 1
    5. Select a different skin tone on the other platform (from step 4)
    6. Navigate back to the original platform and open the emoji picker
    7. Verify that the selected emoji skin tone is set to only one, not two
    
    
    

    Do we agree 👍 or 👎

  18. strepanier03 commented on Dec 19, 2024

    @strepanier03
    Contributor

    Payment Summary

  19. strepanier03 commented on Dec 19, 2024

    @strepanier03
    Contributor

    I've paid and closed both contracts, plus I've made the reg test GH. Closing this out.

  20. changed the title [-][HOLD for payment 2024-12-19] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/-] [+][PAID] [$250] Chat - Two emoji skin tones are displayed after changing tone in browser[/+] on Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions