Skip to content

[HOLD for payment 2024-12-09] [$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms #52933

Closed

Description

@jamesdeanexpensify

Details

Coming from this convo, I noticed that when you go into any #admins room and click into the Members section, near the top it doesn't show the room name:

image

In any other room, it does:

image

cc @Expensify/design

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859707716941961146
  • Upwork Job ID: 1859707716941961146
  • Last Price Increase: 2024-11-21
  • Automatic offers:
    • Krishna2323 | Contributor | 105068916
Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  2. Krishna2323 commented on Nov 21, 2024

    @Krishna2323
    Contributor

    Proposal


    Please re-state the problem that we are trying to solve in this issue.

    BUG: "Members" section of #admins room doesn't have room name near the top like other rooms

    What is the root cause of that problem?

    • Subtitle is not passed to HeaderWithBackButton.
      <HeaderWithBackButton
      title={selectionModeHeader ? translate('common.selectMultiple') : headerTitle}
      onBackButtonPress={() => {
      if (selectionMode?.isEnabled) {
      setSelectedMembers([]);
      turnOffMobileSelectionMode();
      return;
      }
      if (report) {
      setSearchValue('');
      Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(report.reportID, backTo));
      }
      }}
      guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_MEMBERS}
      />

    What changes do you think we should make in order to solve the problem?


    Pass subtitle={StringUtils.lineBreaksToSpaces(ReportUtils.getReportName(report))} to HeaderWithBackButton.

    What alternative solutions did you explore? (Optional)

    Result

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 21, 2024
  4. melvin-bot commented on Nov 21, 2024

    @melvin-bot
  5. changed the title [-]BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/-] [+][$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/+] on Nov 21, 2024
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 21, 2024
  7. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  8. self-assigned this
    on Nov 21, 2024
  9. FitseTLT commented on Nov 21, 2024

    @FitseTLT
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-11-21 21:15:47 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    BUG: "Members" section of #admins room doesn't have room name near the top like other rooms

    What is the root cause of that problem?

    We haven't given the report name as subtitle to HeaderWithBackButton

    title={selectionModeHeader ? translate('common.selectMultiple') : headerTitle}

    What changes do you think we should make in order to solve the problem?

    We can give the report name as the subtitle for default rooms

                        subtitle={ReportUtils.isDefaultRoom(report) ? StringUtils.lineBreaksToSpaces(ReportUtils.getReportName(report)) : undefined}
    

    If we want we can do the same for isGroupChat too

    What alternative solutions did you explore? (Optional)

    We can optionally apply it to isAdminRoom only if we want (or even isAnnounceRoom) or may be isGroupChat case too but for other case as iou reports expense reports etc... we surely don't want to show the names

  10. mkzie2 commented on Nov 22, 2024

    @mkzie2
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-11-22 11:11:34 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Members" section of #admins room doesn't have room name near the top like other rooms

    What is the root cause of that problem?

    For the chat room, the member page is in RoomMembersPage and we have a subtitle in the header is the room name here

    subtitle={StringUtils.lineBreaksToSpaces(ReportUtils.getReportName(report))}

    For other reports, the member page is in ReportParticipantsPage and we don't pass subtitle prop to HeaderWithBackButton then no report name section is displayed

    <HeaderWithBackButton

    What changes do you think we should make in order to solve the problem?

    The default room exists for all workspaces so I think we can display the subtitle with the workspace name, it's more useful for the user to know

    1. We can get the additional detail like here and because we only want to display it for the default room of the workspace, we can only get the case in ${chatRoomSubtitle}
    const chatRoomSubtitle = useMemo(() => ReportUtils.getChatRoomSubtitle(report), [report, policy]);
    const additionalRoomDetails = `${translate('threads.in')} ${chatRoomSubtitle}`;
    
    
    1. Pass subtitle prop here
    subtitle={ReportUtils.isDefaultRoom(report) ? `${StringUtils.lineBreaksToSpaces(ReportUtils.getReportName(report))} ${additionalRoomDetails}` : ''}
    

    <HeaderWithBackButton

    Optional: We can do the same for the chat room member page in RoomMembersPage

    What alternative solutions did you explore? (Optional)

    We can apply the main solution for only special reports that we want like admin, and announce or for report with isChatRoom is true.

    We can also apply the main solution for other reports like group chat, ... but we will only display the report name in this case

    Result

    Screenshot 2024-11-22 at 12 06 45
  11. mkzie2 commented on Nov 22, 2024

    @mkzie2
    Contributor

    @dubielzyk-expensify What do you think about my result above? Display #admin with workspace is more useful for the user to know the workspace of this admin room when visiting the member page.

  12. 22 remaining items

  13. changed the title [-][$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/-] [+][HOLD for payment 2024-12-09] [$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/+] on Dec 2, 2024
  14. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-09. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    @dukenv0307 @OfstadC @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. OfstadC commented on Dec 6, 2024

    @OfstadC
    Contributor

    @dukenv0307 Please complete checklist before payment date. Thank you 😃

  18. dukenv0307 commented on Dec 7, 2024

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: This is new requirement so we don't need offending PR.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template

    Regression Test Proposal

    Test:

    1. Go to workspace admins room
    2. Click on header > click on members
    3. Verify subtitle #admins is shown in the header
    4. Go to workspace announce room
    5. Click on header > click on members
    6. Verify subtitle #announce is shown in the header

    Do we agree 👍 or 👎

  19. dukenv0307 commented on Dec 7, 2024

    @dukenv0307
    Contributor

    @OfstadC I completed

  20. OfstadC commented on Dec 9, 2024

    @OfstadC
    Contributor

    Payment Summary

  21. JmillsExpensify commented on Dec 16, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions