You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-09] [$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms #52933
Coming from this convo, I noticed that when you go into any #admins room and click into the Members section, near the top it doesn't show the room name:
changed the title [-]BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/-][+][$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/+]on Nov 21, 2024
What alternative solutions did you explore? (Optional)
We can optionally apply it to isAdminRoom only if we want (or even isAnnounceRoom) or may be isGroupChat case too but for other case as iou reports expense reports etc... we surely don't want to show the names
For other reports, the member page is in ReportParticipantsPage and we don't pass subtitle prop to HeaderWithBackButton then no report name section is displayed
What changes do you think we should make in order to solve the problem?
The default room exists for all workspaces so I think we can display the subtitle with the workspace name, it's more useful for the user to know
We can get the additional detail like here and because we only want to display it for the default room of the workspace, we can only get the case in ${chatRoomSubtitle}
@dubielzyk-expensify What do you think about my result above? Display #admin with workspace is more useful for the user to know the workspace of this admin room when visiting the member page.
changed the title [-][$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/-][+][HOLD for payment 2024-12-09] [$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/+]on Dec 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@OfstadC@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This is new requirement so we don't need offending PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 21, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Nov 21, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
BUG: "Members" section of #admins room doesn't have room name near the top like other rooms
What is the root cause of that problem?
HeaderWithBackButton.App/src/pages/ReportParticipantsPage.tsx
Lines 367 to 382 in 93f7874
What changes do you think we should make in order to solve the problem?
Pass
subtitle={StringUtils.lineBreaksToSpaces(ReportUtils.getReportName(report))}toHeaderWithBackButton.What alternative solutions did you explore? (Optional)
Result
melvin-bot commentedon Nov 21, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021859707716941961146
[-]BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/-][+][$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/+]melvin-bot commentedon Nov 21, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)FitseTLT commentedon Nov 21, 2024
Edited by proposal-police: This proposal was edited at 2024-11-21 21:15:47 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
BUG: "Members" section of #admins room doesn't have room name near the top like other rooms
What is the root cause of that problem?
We haven't given the report name as subtitle to HeaderWithBackButton
App/src/pages/ReportParticipantsPage.tsx
Line 368 in e9e1857
What changes do you think we should make in order to solve the problem?
We can give the report name as the subtitle for default rooms
If we want we can do the same for
isGroupChattooWhat alternative solutions did you explore? (Optional)
We can optionally apply it to
isAdminRoomonly if we want (or even isAnnounceRoom) or may be isGroupChat case too but for other case as iou reports expense reports etc... we surely don't want to show the namesmkzie2 commentedon Nov 22, 2024
Edited by proposal-police: This proposal was edited at 2024-11-22 11:11:34 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Members" section of #admins room doesn't have room name near the top like other rooms
What is the root cause of that problem?
For the chat room, the member page is in
RoomMembersPageand we have asubtitlein the header is the room name hereApp/src/pages/RoomMembersPage.tsx
Line 356 in 686b8b4
For other reports, the member page is in
ReportParticipantsPageand we don't passsubtitleprop toHeaderWithBackButtonthen no report name section is displayedApp/src/pages/ReportParticipantsPage.tsx
Line 367 in 686b8b4
What changes do you think we should make in order to solve the problem?
The default room exists for all workspaces so I think we can display the subtitle with the workspace name, it's more useful for the user to know
in ${chatRoomSubtitle}subtitleprop hereApp/src/pages/ReportParticipantsPage.tsx
Line 367 in 686b8b4
Optional: We can do the same for the chat room member page in
RoomMembersPageWhat alternative solutions did you explore? (Optional)
We can apply the main solution for only special reports that we want like admin, and announce or for report with
isChatRoomistrue.We can also apply the main solution for other reports like group chat, ... but we will only display the report name in this case
Result
mkzie2 commentedon Nov 22, 2024
@dubielzyk-expensify What do you think about my result above? Display
#adminwith workspace is more useful for the user to know the workspace of this admin room when visiting the member page.22 remaining items
[-][$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/-][+][HOLD for payment 2024-12-09] [$250] BUG: "Members" section of #admins room doesn't have room name near the top like other rooms[/+]melvin-bot commentedon Dec 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 2, 2024
@dukenv0307 @OfstadC @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
OfstadC commentedon Dec 6, 2024
@dukenv0307 Please complete checklist before payment date. Thank you 😃
dukenv0307 commentedon Dec 7, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This is new requirement so we don't need offending PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/451670
Regression Test Proposal
Test:
Do we agree 👍 or 👎
dukenv0307 commentedon Dec 7, 2024
@OfstadC I completed
OfstadC commentedon Dec 9, 2024
Payment Summary
JmillsExpensify commentedon Dec 16, 2024
$250 approved for @dukenv0307