You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Chat - There is no “Take a 2-minute tour” task at the Concierge chat #52985
Version Number: 9.0.66-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Log in with the new Gmail account in incognito mode
Complete the incorporation process using the option “Track and Budge Expenses”
Enter a first name and click on the Continue button
Go to the Concierge chat.
Expected Result:
A task “Take a 2-minute tour” must be displayed in the Concierge chat
Actual Result:
The “Take a 2-minute tour” task is not displayed in the Concierge chat. In some cases when executing the tour action, you hear the sound as of a completed task but nothing is displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidencebandicam.2024-11-22.23-24-32-898.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀
Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀
@chiragsalian, Not sure, I could produce the issue even by entering first and last name.
No problem, I was missing that too :D thanks for letting us know @Shahidullah-Muffakir. I'll fill out the BZ checklist in a moment. Thanks @CortneyOfstad
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Log in with a new account
Complete the onboarding process by selecting Track and Budget Expenses in the onboarding flow.
Verify the Take a 2-minute tour task appears in the Concierge chat.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Tasks for guided setup #39951 (comment)
Actually, the issue was introduced by this PR: #51153. The self guided tour task did not exist when we implemented this PR :)
Activity
melvin-bot commentedon Nov 22, 2024
Triggered auto assignment to @chiragsalian (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 22, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Nov 22, 2024
Production:
Bug6673595_1732311343627.Issue.mp4
chiragsalian commentedon Nov 22, 2024
Both the recorded videos are of production so i think maybe you made a mistake there? Can you double check @lanitochka17.
I tested the same steps on staging with a new account and i see

Take a 2-minute tour.lanitochka17 commentedon Nov 22, 2024
sorry for confusion
correct video:
bandicam.2024-11-22.23-24-32-898.mp4
Shahidullah-Muffakir commentedon Nov 22, 2024
Edited by proposal-police: This proposal was edited at 2024-11-22 22:31:44 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Take a 2-minute tour is not shown in concierge for Track and Budge Expenses
What is the root cause of that problem?
we did not include
selfGuidedTourTaskin the tasks if the tour purpose iscombinedTrackSubmitOnboardingChoices.PERSONAL_SPEND:in
App/src/CONST.ts
Lines 212 to 226 in 3ebe852
What changes do you think we should make in order to solve the problem?
add selfGuidedTourTask to it as:
const combinedTrackSubmitOnboardingPersonalSpendMessage: OnboardingMessage = { ...onboardingPersonalSpendMessage, tasks: [ + selfGuidedTourTask, { type: 'trackExpense',Screen.20Recording.202024-11-23.20at.204.mp4
chiragsalian commentedon Nov 23, 2024
Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀
chiragsalian commentedon Nov 23, 2024
But yeah your solution works @Shahidullah-Muffakir, feel free to create the PR. I will be heading out now but we can CP it early on Monday.
Shahidullah-Muffakir commentedon Nov 23, 2024
@chiragsalian, Not sure, I could produce the issue even by entering first and last name.
27 remaining items
CortneyOfstad commentedon Dec 5, 2024
@Shahidullah-Muffakir can you confirm if this needs a regression test?
Also, I've sent you a proposal here in Upwork — please let me know once you accept. Thanks!
Shahidullah-Muffakir commentedon Dec 5, 2024
@CortneyOfstad ,
@brunovjk has reviewed the PR as C+.
Offer Accepted, Thanks!
CortneyOfstad commentedon Dec 6, 2024
Oops, sorry about that! @brunovjk can you confirm if this needs a regression test? Thanks!
Also, it looks like you need payment as well — going to whip up an Upwork proposal and get that sent over ASAP!
brunovjk commentedon Dec 6, 2024
No problem, I was missing that too :D thanks for letting us know @Shahidullah-Muffakir. I'll fill out the BZ checklist in a moment. Thanks @CortneyOfstad
CortneyOfstad commentedon Dec 6, 2024
@brunovjk proposal has been sent here!
brunovjk commentedon Dec 6, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Self-guided tours][V2] Add tour links to onboarding tasks #51153 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Track and Budget Expensesin the onboarding flow.Take a 2-minute tourtask appears in theConciergechat.Do we agree 👍 or 👎
brunovjk commentedon Dec 6, 2024
All yours @CortneyOfstad :D
rayane-d commentedon Dec 6, 2024
Actually, the issue was introduced by this PR: #51153. The self guided tour task did not exist when we implemented this PR :)
brunovjk commentedon Dec 6, 2024
I updated the BZ checklist and posted the comment in the aforementioned PR. Thank you @rayane-djouah
CortneyOfstad commentedon Dec 9, 2024
Payment Summary
@brunovjk — paid $250 via Upwork
@Shahidullah-Muffakir — paid $250 via Upwork
Regression Test
https://github.com/Expensify/Expensify/issues/451766