Skip to content

[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Chat - There is no “Take a 2-minute tour” task at the Concierge chat #52985

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with the new Gmail account in incognito mode
  3. Complete the incorporation process using the option “Track and Budge Expenses”
  4. Enter a first name and click on the Continue button
  5. Go to the Concierge chat.

Expected Result:

A task “Take a 2-minute tour” must be displayed in the Concierge chat

Actual Result:

The “Take a 2-minute tour” task is not displayed in the Concierge chat. In some cases when executing the tour action, you hear the sound as of a completed task but nothing is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
bandicam.2024-11-22.23-24-32-898.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Nov 22, 2024

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Nov 22, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Nov 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Nov 22, 2024

    @lanitochka17
    Author

    Production:

    Bug6673595_1732311343627.Issue.mp4
  5. chiragsalian commented on Nov 22, 2024

    @chiragsalian
    Contributor

    Both the recorded videos are of production so i think maybe you made a mistake there? Can you double check @lanitochka17.

    I tested the same steps on staging with a new account and i see Take a 2-minute tour.
    image

  6. lanitochka17 commented on Nov 22, 2024

    @lanitochka17
    Author

    sorry for confusion
    correct video:

    bandicam.2024-11-22.23-24-32-898.mp4
  7. Shahidullah-Muffakir commented on Nov 22, 2024

    @Shahidullah-Muffakir
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-11-22 22:31:44 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Take a 2-minute tour is not shown in concierge for Track and Budge Expenses

    What is the root cause of that problem?

    we did not include selfGuidedTourTask in the tasks if the tour purpose is combinedTrackSubmitOnboardingChoices.PERSONAL_SPEND:
    in

    App/src/CONST.ts

    Lines 212 to 226 in 3ebe852

    const combinedTrackSubmitOnboardingPersonalSpendMessage: OnboardingMessage = {
    ...onboardingPersonalSpendMessage,
    tasks: [
    {
    type: 'trackExpense',
    autoCompleted: false,
    title: 'Track an expense',
    description:
    '*Track an expense* in any currency, whether you have a receipt or not.\n' +
    '\n' +
    'Here’s how to track an expense:\n' +
    '\n' +
    '1. Click the green *+* button.\n' +
    '2. Choose *Create expense*.\n' +
    '3. Enter an amount or scan a receipt.\n' +

    What changes do you think we should make in order to solve the problem?

    add selfGuidedTourTask to it as:

    const combinedTrackSubmitOnboardingPersonalSpendMessage: OnboardingMessage = {
        ...onboardingPersonalSpendMessage,
        tasks: [
    +        selfGuidedTourTask,
    
            {
                type: 'trackExpense',
    Screen.20Recording.202024-11-23.20at.204.mp4
  8. chiragsalian commented on Nov 23, 2024

    @chiragsalian
    Contributor

    Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀

  9. chiragsalian commented on Nov 23, 2024

    @chiragsalian
    Contributor

    But yeah your solution works @Shahidullah-Muffakir, feel free to create the PR. I will be heading out now but we can CP it early on Monday.

  10. Shahidullah-Muffakir commented on Nov 23, 2024

    @Shahidullah-Muffakir
    Contributor

    Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀

    @chiragsalian, Not sure, I could produce the issue even by entering first and last name.

  11. 27 remaining items

  12. CortneyOfstad commented on Dec 5, 2024

    @CortneyOfstad
    Contributor

    @Shahidullah-Muffakir can you confirm if this needs a regression test?

    Also, I've sent you a proposal here in Upwork — please let me know once you accept. Thanks!

  13. Shahidullah-Muffakir commented on Dec 5, 2024

    @Shahidullah-Muffakir
    Contributor

    @Shahidullah-Muffakir can you confirm if this needs a regression test?

    Also, I've sent you a proposal here in Upwork — please let me know once you accept. Thanks!

    @CortneyOfstad ,
    @brunovjk has reviewed the PR as C+.
    Offer Accepted, Thanks!

  14. CortneyOfstad commented on Dec 6, 2024

    @CortneyOfstad
    Contributor

    Oops, sorry about that! @brunovjk can you confirm if this needs a regression test? Thanks!

    Also, it looks like you need payment as well — going to whip up an Upwork proposal and get that sent over ASAP!

  15. brunovjk commented on Dec 6, 2024

    @brunovjk
    Contributor

    No problem, I was missing that too :D thanks for letting us know @Shahidullah-Muffakir. I'll fill out the BZ checklist in a moment. Thanks @CortneyOfstad

  16. CortneyOfstad commented on Dec 6, 2024

    @CortneyOfstad
    Contributor

    @brunovjk proposal has been sent here!

  17. brunovjk commented on Dec 6, 2024

    @brunovjk
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other: Applause - Internal Team
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [Self-guided tours][V2] Add tour links to onboarding tasks #51153 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. Log in with a new account
    2. Complete the onboarding process by selecting Track and Budget Expenses in the onboarding flow.
    3. Verify the Take a 2-minute tour task appears in the Concierge chat.

    Do we agree 👍 or 👎

  18. brunovjk commented on Dec 6, 2024

    @brunovjk
    Contributor

    All yours @CortneyOfstad :D

  19. rayane-d commented on Dec 6, 2024

    @rayane-d
    Contributor
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
      Link to comment: Tasks for guided setup #39951 (comment)

    Actually, the issue was introduced by this PR: #51153. The self guided tour task did not exist when we implemented this PR :)

  20. brunovjk commented on Dec 6, 2024

    @brunovjk
    Contributor

    I updated the BZ checklist and posted the comment in the aforementioned PR. Thank you @rayane-djouah

  21. CortneyOfstad commented on Dec 9, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @brunovjk — paid $250 via Upwork
    @Shahidullah-Muffakir — paid $250 via Upwork

    Regression Test

    https://github.com/Expensify/Expensify/issues/451766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions