Skip to content

[HOLD for payment 2024-01-03][$250] [Search v1.2] - Pay button does not appear when user owes money after deleting expense #52999

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+kh0911002@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Send an expense ($10) to user B.
  3. [User B] Send an expense of higher amount ($20) to User A.
  4. [User B] Go to Search > Outstanding.
  5. [User B] Select the expense submitted in Step 3.
  6. [User B] Click dropdown button > Delete expense.
  7. [User B] Delete the expense.

Expected Result:

Pay button should appear next to the expense in Search for User B because now User B owes User A money.

Actual Result:

Pay button does not appear next to the expense in Search for User B unless the page is refreshed.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6673842_1732335839110.20241123_121641.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021860331085417429817
  • Upwork Job ID: 1860331085417429817
  • Last Price Increase: 2024-11-23
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    and removed on Nov 23, 2024
  2. melvin-bot commented on Nov 23, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 23, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Nov 23, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Nov 23, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 23, 2024
  7. 55 remaining items

  8. luacmartins commented on Jan 2, 2025

    @luacmartins
    Contributor

    PR merged, should be deployed today

  9. luacmartins commented on Jan 3, 2025

    @luacmartins
    Contributor

    This is fixed in staging. @isabelastisser I'll keep the issue open to process payment to @dominictb since they reviewed this PR, although it was reverted due to a regression.

  10. changed the title [-][$250] [Search v1.2] - Pay button does not appear when user owes money after deleting expense[/-] [+][HOLD for payment 2024-01-10][$250] [Search v1.2] - Pay button does not appear when user owes money after deleting expense[/+] on Jan 3, 2025
  11. changed the title [-][HOLD for payment 2024-01-10][$250] [Search v1.2] - Pay button does not appear when user owes money after deleting expense[/-] [+][HOLD for payment 2024-01-03][$250] [Search v1.2] - Pay button does not appear when user owes money after deleting expense[/+] on Jan 3, 2025
  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Jan 3, 2025
  13. isabelastisser commented on Jan 6, 2025

    @isabelastisser
    Contributor

    @carlosmiceli, thanks for the heads up! @dominictb, does it mean that your PR was not used to fix this issue? Can you please clarify if payment is still required here? Thanks!

  14. dominictb commented on Jan 7, 2025

    @dominictb
    Contributor

    @isabelastisser I helped reviewing #53722 but it then was reverted and decided to fix in the BE. So no checklist is needed and payment for me is required.

  15. isabelastisser commented on Jan 7, 2025

    @isabelastisser
    Contributor

    Got it, @dominictb! Thanks for the context. I will process the payment in Upwork, can you please share your Upwork profile?

  16. dominictb commented on Jan 8, 2025

    @dominictb
    Contributor
  17. isabelastisser commented on Jan 8, 2025

    @isabelastisser
    Contributor

    @dominictb, I sent you the offer in Upwork now. All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions