Skip to content

[HOLD for payment 2025-01-13] [$250] Another invoice can't be sent after one is paid #53019

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation (hyperlinked to channel name): Expensify billpay

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace if needed
  3. Go to More features, scroll down and enable Invoices
  4. Click green plus, Send invoice
  5. Send an invoice to User B
  6. As User B Go to invoice chat and pay the invoice as business
  7. [User A] Go to invoice report
  8. [User A] Click Add bank account
  9. [User A] In settings Add bank account
  10. Click on the bank account for invoicing and choose to make it the default
  11. Click the green plus, send a $2 to user B
  12. Open the invoice report

Expected Result:

The invoice report can be opened

Actual Result:

The invoice report is not found, because it failed to actually be created even though there was no error message shown in product. The Network response shows 400 Unique Constraints Violation
Backlogs : https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%228e6c7cac282da4d0-MIA%22)+AND+timestamp:[2024-11-22T21:51:56.285Z+TO+2024-11-22T23:51:56.285Z]&index=logs_expensify-031332

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.787.mp4
MultipeInvoicesFail2024-11-22_17-52-27.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861805315178904377
  • Upwork Job ID: 1861805315178904377
  • Last Price Increase: 2024-12-04
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 23, 2024
  2. melvin-bot commented on Nov 23, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 27, 2024

    @melvin-bot

    @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. zanyrenney commented on Nov 27, 2024

    @zanyrenney
    Contributor

    triaged the bug.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 27, 2024
  6. changed the title [-]Another invoice can't be sent after one is paid[/-] [+][$250] Another invoice can't be sent after one is paid[/+] on Nov 27, 2024
  7. melvin-bot commented on Nov 27, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 27, 2024
  9. melvin-bot commented on Nov 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

  10. allgandalf commented on Dec 2, 2024

    @allgandalf
    Contributor

    Waiting for proposals

  11. 31 remaining items

  12. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allgandalf requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @allgandalf @zanyrenney @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Jan 7, 2025
  15. allgandalf commented on Jan 9, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: There is no source this case was never considered!

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A (This was never considered, it has been this way since the beginning)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create a workspace > Go to More features, scroll down and enable Invoices
    2. Click green plus, Send invoice
    3. Send an invoice to User B
    4. As User B Go to invoice chat and pay the invoice as business
    5. [User A] Go to invoice report
    6. [User A] Click Add bank account
    7. [User A] In settings Add bank account
    8. Click on the bank account for invoicing and choose to make it the default
    9. Click the green plus, send any amount to user B
    10. Open the invoice report and verify it loads successfully

    Do we agree 👍 or 👎

  16. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@zanyrenney)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1861805315178904377/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. zanyrenney commented on Jan 13, 2025

    @zanyrenney
    Contributor

    @allgandalf invited you to the job!

  18. zanyrenney commented on Jan 13, 2025

    @zanyrenney
    Contributor
  19. allgandalf commented on Jan 15, 2025

    @allgandalf
    Contributor

    Accepted thanks!!

  20. zanyrenney commented on Jan 15, 2025

    @zanyrenney
    Contributor

    can you double-check @allgandalf - it doesn't look like you have in upwork. Thanks! normally here we see "view hires" here if the offer has been accepted

    Image

  21. zanyrenney commented on Jan 16, 2025

    @zanyrenney
    Contributor

    payment summary

    paid $250 to @allgandalf via upwork.

  22. moved this from Hold for Payment to Done in #expensify-bugson Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions