You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
RBR is shown in the report preview for the pending card transaction even though these reports can be approved #53026
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@tgolen Slack conversation (hyperlinked to channel name): expensify bugs
Action Performed:
Submit a card expense to the approver
As a approver open the expense (card expense is not merged yet)
Observe there is a GBR in the LHN and RBR in the report preview
Expected Result:
Since the card transaction can be approved even in if the card transaction is in pending state there should be GBR
Actual Result:
RBR is shown for the card transactions
It would be nice then if it was a green dot and the text was more like "Approve without waiting for credit card merge [APPROVE]"
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
We are currently using the hasErrors field as the condition to display the RBR on the report preview. However, we have not yet included conditions to account for pending card transactions
What changes do you think we should make in order to solve the problem?
The main solution: Display GBR instead of RBR
The hasErrors field should be set to false if hasAllPendingRTERViolations is true.
I've read the Slack thread, I'm not 100% sure what the right move here is. I think the confusing thing is that we have GBR in LHN and RBR on the report. This feels conflicting. cc @JmillsExpensify and @trjExpensify here too
Yeah, I'm not sure what the best answer is either, curious for Jason & Tom's thoughts.
Also cc @dannymcclain this is another place where we need to consider how the category/tag line on an expense preview will look alongside this "Receipt pending match with card transaction" message...
Good call. I'm a bit confused though—I was initially going to say we could treat it the same way as the pending card transaction with something next to the "Card" eyebrow: Card • Pending or Card • Receipt matching or something... But looking at the screenshot, that preview looks like it's a report preview, not an expense preview? The eyebrow text "NewDot Test EC Feed only - Expensify coffee owes:" is worded like a report, not an expense? Have I lost all my marbles here?
Ah good observation, I think you are right. I'd be curious what this one looks like at the expense level, if it even exists? cc @grgia for thoughts there
Yeah, I'm not sure what the best answer is either, curious for Jason & Tom's thoughts.
We're removing the GBR that's showing to the approver if all the transactions on the report are pending in this issue, because there's not really any action for them to take yet. The PR for that is up for review.
I would say that the answer to that question is yes, as you still need to fix issues/violations if they are present (and as long as the underlying report is not closed/reimbursed).
That said, I want to make sure that this initiative remains consistent with this issue, and this comment in particular.
Okay cool, so the report in this context with only pending transactions on it isn't reimbursed or closed, so the red dot should appear, right?
Red dots appear on expense report and transaction preview components as long as violations/rules have been broken and the report is not reimbursed or closed.
Activity
melvin-bot commentedon Nov 23, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Nov 23, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
cretadn22 commentedon Nov 24, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
RBR is shown in the report preview for the pending card transaction even though these reports can be approved
What is the root cause of that problem?
App/src/components/ReportActionItem/ReportPreview.tsx
Lines 157 to 164 in 3ebe852
We are currently using the hasErrors field as the condition to display the RBR on the report preview. However, we have not yet included conditions to account for pending card transactions
What changes do you think we should make in order to solve the problem?
The main solution: Display GBR instead of RBR
The hasErrors field should be set to false if hasAllPendingRTERViolations is true.
App/src/components/MoneyReportHeader.tsx
Line 115 in 3ebe852
App/src/components/MoneyReportHeader.tsx
Line 117 in 3ebe852
Additionally, we need to include the conditions (.... && hasAllPendingRTERViolations && hasOnlyPendingTransactions) to display GBR.
App/src/components/ReportActionItem/ReportPreview.tsx
Line 496 in 3ebe852
Note: The hasAllPendingRTERViolations condition is sufficient to fix this issue, while hasOnlyPendingTransactions is optional.
What alternative solutions did you explore? (Optional)
The alternative solution: Hide RBR
The hasErrors field should be set to false if hasAllPendingRTERViolations is true.
App/src/components/MoneyReportHeader.tsx
Line 115 in 3ebe852
App/src/components/MoneyReportHeader.tsx
Line 117 in 3ebe852
jliexpensify commentedon Nov 24, 2024
Tagging in @Expensify/design to weigh in on any thoughts on text/how we communicate this to users. This sounds like a new feature.
dubielzyk-expensify commentedon Nov 25, 2024
I've read the Slack thread, I'm not 100% sure what the right move here is. I think the confusing thing is that we have GBR in LHN and RBR on the report. This feels conflicting. cc @JmillsExpensify and @trjExpensify here too
shawnborton commentedon Nov 25, 2024
Yeah, I'm not sure what the best answer is either, curious for Jason & Tom's thoughts.
Also cc @dannymcclain this is another place where we need to consider how the category/tag line on an expense preview will look alongside this "Receipt pending match with card transaction" message...
dannymcclain commentedon Nov 25, 2024
Good call. I'm a bit confused though—I was initially going to say we could treat it the same way as the pending card transaction with something next to the "Card" eyebrow:
Card • PendingorCard • Receipt matchingor something... But looking at the screenshot, that preview looks like it's a report preview, not an expense preview? The eyebrow text "NewDot Test EC Feed only - Expensify coffee owes:" is worded like a report, not an expense? Have I lost all my marbles here?shawnborton commentedon Nov 25, 2024
Ah good observation, I think you are right. I'd be curious what this one looks like at the expense level, if it even exists? cc @grgia for thoughts there
trjExpensify commentedon Nov 26, 2024
We're removing the GBR that's showing to the approver if all the transactions on the report are pending in this issue, because there's not really any action for them to take yet. The PR for that is up for review.
JmillsExpensify commentedon Nov 27, 2024
What Tom said.
1 remaining item
JmillsExpensify commentedon Nov 27, 2024
I would say that the answer to that question is yes, as you still need to fix issues/violations if they are present (and as long as the underlying report is not closed/reimbursed).
That said, I want to make sure that this initiative remains consistent with this issue, and this comment in particular.
trjExpensify commentedon Nov 27, 2024
Okay cool, so the report in this context with only pending transactions on it isn't
reimbursedorclosed, so the red dot should appear, right?JmillsExpensify commentedon Nov 27, 2024
Do we only close the report once the transaction is posted? If so, then yes your statement sounds right to me.
trjExpensify commentedon Nov 28, 2024
In the instant+no approvals case? Yah.
melvin-bot commentedon Nov 28, 2024
@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Dec 2, 2024
@jliexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
jliexpensify commentedon Dec 2, 2024
Apologies, just catching up here - so if I'm understanding correctly, we want to move forward with fixing this so the 🔴 appears in the LHN?
trjExpensify commentedon Dec 4, 2024
For which user now?
jliexpensify commentedon Dec 4, 2024
Sorry, the LHN for the approver (i.e. @tgolen in this case)
trjExpensify commentedon Dec 4, 2024
Gotcha. Nope, it should not.
dannymcclain commentedon Dec 5, 2024
So @trjExpensify is there anything here that actually needs to be fixed? I'm getting quite confused.
trjExpensify commentedon Dec 5, 2024
I don't think so, because the GBR in the LHN is being removed in this issue: #52315
jliexpensify commentedon Dec 5, 2024
Awesome, thanks Tom - closing!