Skip to content

Blank screen displayed after login #5305

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log out of New Expensify
  2. Log back in with the same account

Expected Result:

User is able to log in

Actual Result:

Blank screen displayed and a JS error is thrown in console.

Workaround:

Refresh fixes the blank screen.

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.0.99-0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
I was unable to reproduce on my side. @AndrewGable is able to repro every time.

image

Expensify/Expensify Issue URL:

Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1631816294393100

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Sep 16, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. OSBotify commented on Sep 16, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. removed their assignment
    on Sep 16, 2021
  4. marcaaron commented on Sep 16, 2021

    @marcaaron
    Contributor

    I'm not sure what PR is causing this but it seems clear from the error message in the JS console that we are trying to access a value before an Onyx.connect() callback has set the value:

    let timezone;
    Onyx.connect({
    key: ONYXKEYS.MY_PERSONAL_DETAILS,
    callback: (val) => {
    timezone = val ? val.timezone : CONST.DEFAULT_TIME_ZONE;
    },
    });

    return moment.unix(timestamp).tz(timezone.selected);
    }

  5. kidroca commented on Sep 16, 2021

    @kidroca
    Contributor

    In that case can we change the code from

    let timezone;
    Onyx.connect({
    key: ONYXKEYS.MY_PERSONAL_DETAILS,
    callback: (val) => {
    timezone = val ? val.timezone : CONST.DEFAULT_TIME_ZONE;
    },
    });

    to:

     let timezone = CONST.DEFAULT_TIME_ZONE;; 
     Onyx.connect({ 
         key: ONYXKEYS.MY_PERSONAL_DETAILS, 
         callback: (val) => { 
             timezone = val ? val.timezone : CONST.DEFAULT_TIME_ZONE; 
         }, 
     }); 

    Or maybe even

     let timezone = CONST.DEFAULT_TIME_ZONE;; 
     Onyx.connect({ 
         key: ONYXKEYS.MY_PERSONAL_DETAILS, 
         callback: (val) => { 
             timezone = lodashGet(val, 'timezone', CONST.DEFAULT_TIME_ZONE);
         }, 
     }); 
  6. mallenexpensify commented on Sep 16, 2021

    @mallenexpensify
    Contributor

    Happening to me on staging.new.expensify.com, when I refresh and hard refresh, it doesn't fix it. When I 'command+k' to open chat switch/search, I see names but when I click names 'nothing happens'.
    image

    2021-09-16_12-33-40.mp4
  7. kidroca commented on Sep 16, 2021

    @kidroca
    Contributor

    @mallenexpensify I think you're hitting a different issue as at least you see the LHN and can invoke it, while for the current issue we're stuck on a white screen and can't do the things you're able to do

  8. mallenexpensify commented on Sep 16, 2021

    @mallenexpensify
    Contributor

    Thanks @kidroca , I'll follow along here and, once this issue closes, if I can reproduce my specific issue I'll create a new GH

  9. kidroca commented on Sep 16, 2021

    @kidroca
    Contributor

    Alright I've pushed a PR, I've tested web, mWeb and Android, but I don't have access to a mac ATM It would be great if someone can review and try it out there, otherwise I'll be able to tomorrow 😞

  10. luacmartins commented on Sep 16, 2021

    @luacmartins
    Contributor

    Taking a look at this. Should we CP this to staging once approved?

  11. AndrewGable commented on Sep 16, 2021

    @AndrewGable
    Contributor

    Yes, let's CP the fix

  12. luacmartins commented on Sep 16, 2021

    @luacmartins
    Contributor

    Cool, merged with CP Staging label #5307

  13. francoisl commented on Sep 17, 2021

    @francoisl
    Contributor

    The fix was deployed, @isagoico could you try again please?

  14. isagoico commented on Sep 17, 2021

    @isagoico
    Author

    I was unable to reproduce this issue on my side 🤯 @AndrewGable can you take care of the retest since you were able to repro consistently?

  15. isagoico commented on Sep 17, 2021

    @isagoico
    Author

    Removing the deploy blocker here since @AndrewGable confirmed he was able to login without blank screens #5307 (comment)

  16. kidroca commented on Nov 23, 2021

    @kidroca
    Contributor

    @isagoico Can we close this?

    The merge request with the fix was merged a long time ago: #5307
    I've logged any time spent on the hourly contract

  17. isagoico commented on Nov 23, 2021

    @isagoico
    Author

    Oh I think we're good to close this - we have not experienced this again CC @AndrewGable @mallenexpensify

  18. mallenexpensify commented on Nov 23, 2021

    @mallenexpensify
    Contributor

    Closing! Reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions