Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): ts_external_expensify_expense
Action Performed:
- Navigate to the Search page.
- Search for an expense associated with an Expensify Card transaction that is still in a pending state.
- Observe the expense row in the search results.
Expected Result:
The "Approve" button should not be displayed on the expense row for transactions in a pending state, The button should only appear when the transaction is actionable
Actual Result:
An "Approve" button is displayed for the pending transaction, even though no approval action can be taken at this stage and clicking the "Approve" button results in no action or feedback, as expected for a pending transaction.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
CleanShot.2024-11-25.at.17.43.29.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021863621928114678264
- Upwork Job ID: 1863621928114678264
- Last Price Increase: 2024-12-09
- Automatic offers:
- paultsimura | Reviewer | 105276803
- cretadn22 | Contributor | 105276806
Issue Owner
Current Issue Owner: @saklugerMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Nov 25, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Nov 25, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Shahidullah-Muffakir commentedon Nov 26, 2024
cretadn22 commentedon Nov 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
When navigating to the Search page and searching for an expense associated with a pending Expensify Card transaction, the "Approve" button is incorrectly displayed for the pending transaction
What is the root cause of that problem?
In the condition for displaying the Approve button on the Search page, we have not included checks for pending card transactions.
App/src/libs/SearchUIUtils.ts
Line 298 in 2ce0764
What changes do you think we should make in order to solve the problem?
In here, We need to include conditions to check if all transactions are pending, similar to what we implemented here
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Nov 29, 2024
@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Dec 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021863621928114678264
[-]'Approve' Button Incorrectly Displayed for Pending Expensify Card Transactions[/-][+][$250] 'Approve' Button Incorrectly Displayed for Pending Expensify Card Transactions[/+]39 remaining items
[-][$250] 'Approve' Button Incorrectly Displayed for Pending Expensify Card Transactions[/-][+][HOLD for payment 2024-12-30] [$250] 'Approve' Button Incorrectly Displayed for Pending Expensify Card Transactions[/+]melvin-bot commentedon Dec 23, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 23, 2024
@jjcoffee @sakluger @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sakluger commentedon Dec 27, 2024
Hey @jjcoffee, could you please complete the BZ checklist before payment is due next Monday? Thanks!
jjcoffee commentedon Dec 30, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52441/files#r1899414978
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
(The
SNAPSHOT_IDrefers to the data the search results are based on).Test:
Do we agree 👍 or 👎
sakluger commentedon Dec 30, 2024
Summarizing payment on this issue:
Contributor: @cretadn22 $250, paid via Upwork
Contributor+: @jjcoffee $250, please request on Newdot
garrettmknight commentedon Jan 7, 2025
$250 approved for @jjcoffee