Skip to content

[Due for payment 2025-04-23] Android - Acct/ WS settings - Device buttons navigation bar missing borders #53186

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.67.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Create a workspace if there is no any
  3. Navigate to the workspace settings
  4. Enable More features and enable Workflows, Rules and Invoices options
  5. Navigate to Profile, Invoices, Workflows. Rules and More features

Expected Result:

Device buttons navigation bar has borders and visible

Actual Result:

Device buttons navigation bar is missing borders and barely visible.
The same happens in account settings: Profile, Wallet, Security

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6677580_1732668150153.video_2024-11-26_19-41-09.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861690553730814393
  • Upwork Job ID: 1861690553730814393
  • Last Price Increase: 2024-11-27
  • Automatic offers:
    • paultsimura | Reviewer | 105095159
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 27, 2024
  2. melvin-bot commented on Nov 27, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Nov 27, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Nov 27, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lakchote commented on Nov 27, 2024

    @lakchote
    Contributor

    Not a blocker. It's a minor issue related to UI.

  7. 135 remaining items

  8. mountiny commented on Apr 17, 2025

    @mountiny
    Contributor

    This was a large follow-up, so I think we should bump the price to @shubham1206agra to $375 - not more in my opinion, because there were two deploy blockers that @shubham1206agra was not around for to review, and so we ended up paying another C+ for help there. Unfortunately, the deploy blockers need to be resolved fast to unblock deploys.

    @johncschuster If you dont have any concerns, could you please update the price to $375? thanks!

  9. johncschuster commented on Apr 22, 2025

    @johncschuster
    Contributor

    Sure thing! I've done that now!

  10. johncschuster commented on Apr 24, 2025

    @johncschuster
    Contributor

    Bumped in Slack for the BZ Checklist (particularly, the regression test steps) to be completed so we can close this out.

  11. johncschuster commented on Apr 28, 2025

    @johncschuster
    Contributor

    Still waiting on the BZ Checklist/regression test steps

  12. johncschuster commented on Apr 30, 2025

    @johncschuster
    Contributor

    Bumped in Slack^

  13. shubham1206agra commented on May 1, 2025

    @shubham1206agra
    Contributor

    Regression Test -

    Test 1 (All platforms except Android Native/mWeb Chrome)

    1. Log in with any account.
    2. Turn on the force offline mode.
    3. Go through each screen of the app.
    4. Verify that the Offline Indicator has the correct position when offline.

    Test 2 (Android Native/mWeb Chrome)

    1. Login with any account.
    2. Turn on the force offline mode.
    3. Go through each screen of the app.
    4. Verify that the device button navigation has borders and is visible.
    5. Verify that the Offline Indicator has the correct position when offline.

    Test 3(Android Native)

    1. Login with any account.
    2. Go through each workspace non-modal screen.
    3. Verify that the device button navigation has translucent borders and the content is partially visible inside the navigation bar.
  14. johncschuster commented on May 1, 2025

    @johncschuster
    Contributor

    Thank you! @shubham1206agra, please request payment via NewDot! (Summary here)

  15. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson May 1, 2025
  16. garrettmknight commented on May 13, 2025

    @garrettmknight
    Contributor

    $375 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions