You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-13] [$250] mWeb - Workspace - Input is not auto-focused and keyboard doesn't open when creating a tag #53208
Version Number: 9.0.67-1 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):htad26+tttyyu@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Login to new dot with an account
Create a new workspace
Go to more features > Tags > Enable tags
Navigate to tags page > Add tag
Expected Result:
Tag creation page is opened, the name input is automatically focused and keyboard is opened
Actual Result:
The name input isn't automatically focused and the keyboard is not opened.
Sometimes the focus and the keyboard appear with a delay
I don't think your proposals have the correct RCA and solution. We already use useAutoFocusInput()here which should handle the focus. However, there's a bug that prevents InteractionManager.runAfterInteractions callbacks from executing. Also, useAutoFocusInput() is preferred over autoFocus.
I did some more testing and it appears that specifically in this case InteractionManager callbacks are being blocked by a playing lottie animation on the previous page. If I disable it here by setting autoPlay={false} then autofocus works again.
cc @Themoonalsofall @Shahidullah-Muffakir if you want to investigate this further and update your proposals.
I wasn't able to reproduce this issue on a Pixel 8 Pro emulator so I tried various Browserstack devices and the results are as follows
changed the title [-]mWeb - Workspace - Input is not auto-focused and keyboard doesn't open when creating a tag[/-][+][$250] mWeb - Workspace - Input is not auto-focused and keyboard doesn't open when creating a tag[/+]on Dec 2, 2024
@rayane-d@sonialiap@rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[@sonialiap] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
#### Test:
1. Login to new dot with an account
2. Create a new workspace
3. Go to more features > Tags > Enable tags
4. Navigate to tags page > Add tag
5. Verify Tag creation page is opened, the name input is automatically focused and keyboard is opened
Activity
melvin-bot commentedon Nov 27, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Shahidullah-Muffakir commentedon Nov 28, 2024
andriivitiv commentedon Nov 29, 2024
andriivitiv commentedon Nov 29, 2024
I don't think your proposals have the correct RCA and solution. We already use
useAutoFocusInput()here which should handle the focus. However, there's a bug that preventsInteractionManager.runAfterInteractionscallbacks from executing. Also,useAutoFocusInput()is preferred overautoFocus.andriivitiv commentedon Dec 1, 2024
I did some more testing and it appears that specifically in this case
InteractionManagercallbacks are being blocked by a playing lottie animation on the previous page. If I disable it here by settingautoPlay={false}then autofocus works again.cc @Themoonalsofall @Shahidullah-Muffakir if you want to investigate this further and update your proposals.
I wasn't able to reproduce this issue on a Pixel 8 Pro emulator so I tried various Browserstack devices and the results are as follows
Reproducible
Not reproducible
[-]mWeb - Workspace - Input is not auto-focused and keyboard doesn't open when creating a tag[/-][+][$250] mWeb - Workspace - Input is not auto-focused and keyboard doesn't open when creating a tag[/+]melvin-bot commentedon Dec 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021863569158386608990
73 remaining items
melvin-bot commentedon Feb 6, 2025
@rayane-d @sonialiap @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rayane-d commentedon Feb 8, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/48444/files#r1947702827
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[@sonialiap] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/469979
Regression Test Proposal
Do we agree 👍 or 👎
sonialiap commentedon Feb 13, 2025
Payment summary:
rayane-d commentedon Feb 13, 2025
@sonialiap I will request in NewDot. Can you please update the payment summary?
melvin-bot commentedon Feb 17, 2025
@sonialiap, @MonilBhavsar, @rayane-d, @linhvovan29546 Whoops! This issue is 2 days overdue. Let's get this updated quick!
sonialiap commentedon Feb 17, 2025
@rayane-d updated payment summary to reflect payment in ND :)
garrettmknight commentedon Feb 19, 2025
$250 approved for @rayane-d