You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Search - Search section loads infinitely when opened after logging in #53285
Version Number: 9.0.68-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):ibellicotest+51@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Open the Expensify app.
Log in with any Gmail account.
When logged in, tap on "Search" on the bottom of the screen.
Verify that search section and all the content in it, loads smoothly.
Expected Result:
Search section and all the content in it, should load smoothly when opened.
Actual Result:
Search section loads infinitely when opened just after logging in.
changed the title [-]Search - Search section loads infinitely when opened after logging in[/-][+][$250] Search - Search section loads infinitely when opened after logging in[/+]on Dec 2, 2024
Activity
melvin-bot commentedon Nov 28, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Nov 29, 2024
This is a BE Bug.
SearchAPI returns no Onyx data.huult commentedon Nov 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Search section loads infinitely when opened after logging in
What is the root cause of that problem?
We called the search API with this
jsonQuery, but the response returned an emptyonyxDataarray.The reason for the empty
onyxDataarray might be that the backend validated the query as having the wrong format or something similar.And since
onyxDatais an empty array,shouldShowLoadingStatealways returnsfalse, which is why the loading state is not hidden.App/src/components/Search/index.tsx
Line 222 in 9933888
App/src/components/Search/index.tsx
Line 309 in 9933888
What changes do you think we should make in order to solve the problem?
To resolve this issue, we need to do two things:
onyxDatais an empty array.App/src/components/Search/index.tsx
Line 308 in 9933888
POC
What alternative solutions did you explore? (Optional)
[-]Search - Search section loads infinitely when opened after logging in[/-][+][$250] Search - Search section loads infinitely when opened after logging in[/+]melvin-bot commentedon Dec 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021863519972369952192
melvin-bot commentedon Dec 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)mountiny commentedon Dec 2, 2024
cc @luacmartins @lakchote can you have a look into this?
melvin-bot commentedon Dec 2, 2024
@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
luacmartins commentedon Dec 2, 2024
@daledah the requestID shared here shows no errors for that request. Do you have expense data in that account?
akinwale commentedon Dec 3, 2024
@huult Could you clarify what you mean by "Double-check the JSON query to match the backend's requirements." in your proposed solution?
huult commentedon Dec 3, 2024
@akinwale Yes, I mean we need to check with the backend why this JSON query has returned Onyx with an empty array, and this resolved it
luacmartins commentedon Dec 3, 2024
This is entirely internal. So gonna unassign BZ and C+
luacmartins commentedon Dec 4, 2024
This is fixed