Repository navigation
[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Categorize it -Upgrade success view opens when navigating back from category list/confirm page #53309
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.68-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- Account has no workspace.
- Go to staging.new.expensify.com
- Go to self DM.
- Track a manual expense.
- Tap Categorize it.
- Tap Upgrade.
- Tap Got it, thanks.
- Tap app back button.
- Note that it still opens upgrade success view.
- Tap Got it, thanks.
- Select a category.
- Tap app back button on the confirmation page.
- Note that it still opens upgrade success view.
- Tap app back button again.
- Note that now only category list will open.
Expected Result:
In Step 8 and 12, upgrade success view should be removed from the navigation path once "Got it, thanks" is tapped (similar to what is done here #52091).
Actual Result:
In Step 8 and 12, upgrade success view opens when navigating back to the previous page.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Nov 29, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 29, 2024
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 29, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
trjExpensify commentedon Nov 29, 2024
Yep, let's
dismissclose the RHP if they go back, which would be consistent with other flows. For example:2024-11-29_11-01-46.mp4
14 remaining items
melvin-bot commentedon Nov 30, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 30, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 30, 2024
@Ollyws @trjExpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-12-07] Categorize it -Upgrade success view opens when navigating back from category list/confirm page[/-][+][HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Categorize it -Upgrade success view opens when navigating back from category list/confirm page[/+]melvin-bot commentedon Dec 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 2, 2024
@Ollyws @trjExpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Dec 9, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Dec 9, 2024
This was a fix from the categorize it update PR, so I think we can handle payment there centrally for this, right?
trjExpensify commentedon Dec 11, 2024
Closing this out to consolidate on the OG issue linked.