You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-16] [$75] Tag - In tag details page, no spacing between Go "to and more" features #53358
Version Number: V9. 0.69-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue reported by: Applause Internal Team
Action Performed:
Launch app
Go to workspace settings
Tap more features - enable tags
Add a tag
Open the tag
Enter GL code and complete flow
Go to workspace settings - more features - enable rules
Tap tags
Open a tag
Note text under approver field
Note no spacing between Go "to and more" features
Navigate to workspace settings - category
Open a category
Note text under approver field
Note there is spacing between Go "to and more" features
Expected Result:
In tag details page, there must spacing between Go "to and more" features.
Actual Result:
In tag details page, no spacing between Go "to and more" features but spacing in category details page.
changed the title [-]Tag - In tag details page, no spacing between Go "to and more" features[/-][+][$250] Tag - In tag details page, no spacing between Go "to and more" features[/+]on Dec 3, 2024
changed the title [-][$250] Tag - In tag details page, no spacing between Go "to and more" features[/-][+][$75] Tag - In tag details page, no spacing between Go "to and more" features[/+]on Dec 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@VictoriaExpensify@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A: Due to it isn't an impactful bug
Activity
melvin-bot commentedon Dec 1, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.prakashbask commentedon Dec 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
In tag details page, there must spacing between Go "to and more" features.
What is the root cause of that problem?
There is a space missing after the Text component to render "Go to" in
App/src/pages/workspace/tags/TagSettingsPage.tsx
Line 193 in 7d15aac
What changes do you think we should make in order to solve the problem?
Add a space {' '} after the Text component that is used to render "Go to" in
App/src/pages/workspace/tags/TagSettingsPage.tsx
Line 193 in 7d15aac
This solution is similar to the space added in src/pages/workspace/categories/CategorySettingsPage.tsx
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
VictoriaExpensify commentedon Dec 3, 2024
Yeah we should fix this, but it seems like a super simple copy fix so I'm going to drop the bounty to $75
[-]Tag - In tag details page, no spacing between Go "to and more" features[/-][+][$250] Tag - In tag details page, no spacing between Go "to and more" features[/+]melvin-bot commentedon Dec 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021863808426275105630
melvin-bot commentedon Dec 3, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)[-][$250] Tag - In tag details page, no spacing between Go "to and more" features[/-][+][$75] Tag - In tag details page, no spacing between Go "to and more" features[/+]melvin-bot commentedon Dec 3, 2024
Upwork job price has been updated to $75
19 remaining items
melvin-bot commentedon Dec 9, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-16. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 9, 2024
@suneox @VictoriaExpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Dec 15, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/49937/files#r1885753605
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A: Due to it isn't an impactful bug
melvin-bot commentedon Dec 16, 2024
Payment Summary
Upwork Job
BugZero Checklist (@VictoriaExpensify)
VictoriaExpensify commentedon Dec 16, 2024
@prakashbask and @suneox I've sent you both offers in Upwork. Let me know when you have accepted them and I'll orgnaise payment
prakashbask commentedon Dec 17, 2024
@VictoriaExpensify Thanks. I have accepted the offer in Upwork
suneox commentedon Dec 17, 2024
Thank you! I've accepted the offer
melvin-bot commentedon Dec 20, 2024
@prakashbask, @suneox, @grgia, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
VictoriaExpensify commentedon Dec 22, 2024
Payment Summary:
C: @prakashbask paid $75 via Upwork
C+: @suneox paid $75 via Upwork