You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-02] [$250] iOS - Search - Search page briefly goes blank when switching workspace filter #53359
Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers):applausetester+232803@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Launch ND or hybrid app.
Go to Search.
Open workspace switcher.
Select another workspace (create a workspace first if there isn't any).
Open workspace switcher.
Tap Clear filter.
Expected Result:
Search page will not go blank when switching workspace filter.
Actual Result:
Search page briefly goes blank when switching workspace filter.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@fedirjh@zanyrenney@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Author aware and fixed it.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Open the app
Go to the search tab
Go to the WS switcher
Switch to/Filter by a workspace
Make sure that there is no blank screen when navigating back to the SearchScreen.
Contributor: @kirillzyusko is from an agency-contributor and not due payment - NO PAYMENT.
Reviewer: @fedirjh owed $250 via NewDot - PLEASE REQUEST 250USD.
Activity
melvin-bot commentedon Dec 1, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 1, 2024
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Dec 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 1, 2024
💬 A slack conversation has been started in #expensify-open-source
36 remaining items
melvin-bot commentedon Dec 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 26, 2024
@fedirjh @zanyrenney @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jan 2, 2025
Payment Summary
Upwork Job
BugZero Checklist (@zanyrenney)
zanyrenney commentedon Jan 6, 2025
I have sent a DM to @fedirjh to complete the checklist
fedirjh commentedon Jan 6, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Author aware and fixed it.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
zanyrenney commentedon Jan 7, 2025
https://github.com/Expensify/Expensify/issues/458034
zanyrenney commentedon Jan 7, 2025
Payment Summary
Contributor: @kirillzyusko is from an agency-contributor and not due payment - NO PAYMENT.
Reviewer: @fedirjh owed $250 via NewDot - PLEASE REQUEST 250USD.
garrettmknight commentedon Jan 29, 2025
$250 approved for @fedirjh