Skip to content

[HOLD for payment 2024-12-25] [$250] iOS/Android WS features -Feature is not enabled after enabling it and upgrading workspace to Control #53360

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch hybrid or ND app.
  2. Create a Collect workspace.
  3. Go to More features.
  4. Enable Rules.
  5. Tap Upgrade.
  6. Tap Got it, thanks.

Expected Result:

Rules feature will be enabled after enabling it and upgrading workspace to Control plan (production behavior).

Actual Result:

Rules feature is not enabled after enabling it and upgrading workspace to Control plan. User has to enable it again.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6681091_1733044347819.ScreenRecording_12-01-2024_17-08-41_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863284829899625527
  • Upwork Job ID: 1863284829899625527
  • Last Price Increase: 2024-12-01
  • Automatic offers:
    • CyberAndrii | Contributor | 105222820
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 1, 2024
  2. melvin-bot commented on Dec 1, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Dec 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Dec 1, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Dec 1, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 1, 2024
  7. melvin-bot commented on Dec 1, 2024

    @melvin-bot
  8. 53 remaining items

  9. melvin-bot commented on Jan 3, 2025

    @melvin-bot

    @Ollyws, @kirillzyusko, @mountiny, @CyberAndrii, @muttmuure 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  10. Ollyws commented on Jan 5, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: Migration

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Migrate E/App to use PlatformStackNavigation #49937 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create a Collect workspace
    2. Go to More features
    3. Enable Rules
    4. Tap Upgrade
    5. Tap Got it, thanks
    6. Verify that the Rules feature is enabled
    

    Do we agree 👍 or 👎

  11. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    @Ollyws, @kirillzyusko, @mountiny, @CyberAndrii, @muttmuure 12 days overdue. Walking. Toward. The. Light...

  12. mountiny commented on Jan 7, 2025

    @mountiny
    Contributor

    I am not sure if we need a specific test for this one

  13. muttmuure commented on Jan 7, 2025

    @muttmuure
    Contributor

    @Ollyws $250 C+
    @kirillzyusko does not require payment
    @CyberAndrii $250 Contributor

  14. muttmuure commented on Jan 7, 2025

    @muttmuure
    Contributor

    Andrii is paid, waiting for Olly to submit request

  15. Ollyws commented on Jan 7, 2025

    @Ollyws
    Contributor

    Requested on ND.

  16. garrettmknight commented on Jan 7, 2025

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

  17. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    @Ollyws, @kirillzyusko, @mountiny, @CyberAndrii, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

  18. mountiny commented on Jan 13, 2025

    @mountiny
    Contributor

    I believe we can close now, thanks!

  19. moved this from Hold for Payment to Done in #expensify-bugson Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions