You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Android Hybrid - Login - White screen when backgrounding app after entering magic code #53397
Version Number: 9.0.69-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+60@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Open the Expensify app.
Tap on "Continue With Email"
Enter valid credentials.
Tap on "Next" and wait until receiving the magic code.
Enter the received magic code and tap on "Log In"
While the app is loading, background it.
Wait a few seconds and reopen it.
Verify that the login process was successful and you land on inbox.
Expected Result:
The user should be correctly logged in, despite backgrounding the app during the login process.
Actual Result:
A white screen is displayed when backgrounding the app for a few seconds while loading after entering the received Magic Code. The user has to kill the app and relaunch it to enter the account after this.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-]Android Hybrid - Login - White screen when backgrounding app after entering magic code[/-][+][$250] Android Hybrid - Login - White screen when backgrounding app after entering magic code[/+]on Dec 2, 2024
Sure, usually when Android: Standalone or Android: mWeb Chrome are not checked in the Platforms section and when the issue's title states Android Hybrid we assume this is specific to Android: HybridApp.
Update: I haven't found anything that could lead to recent changes in codebase. I'm continuing investigation
EDIT: It seems like this issue happens only if we want to open NewDot after successful sign-in. I think we might have an issue with ReactNativeActivity start. Perhaps it's not possible to start this activity when app is in background
I managed to find a fix, and I'm preparing a PR so that anyone can verify it. I would also like to test the transition between OD and ND, as well as different scenarios where the app is opened from the background.
Activity
melvin-bot commentedon Dec 2, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 2, 2024
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 2, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
vincdargento commentedon Dec 2, 2024
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
[-]Android Hybrid - Login - White screen when backgrounding app after entering magic code[/-][+][$250] Android Hybrid - Login - White screen when backgrounding app after entering magic code[/+]7 remaining items
ikevin127 commentedon Dec 2, 2024
Sure, usually when
Android: StandaloneorAndroid: mWeb Chromeare not checked in the Platforms section and when the issue's title statesAndroid Hybridwe assume this is specific toAndroid: HybridApp.mountiny commentedon Dec 2, 2024
Assigning myself too as its most likely coming from the native-stack PR that I have pushed ahead. SWM will have a look into this tomorrow
mateuuszzzzz commentedon Dec 3, 2024
Hi, I'm going to investigate this issue
melvin-bot commentedon Dec 3, 2024
📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
mateuuszzzzz commentedon Dec 3, 2024
Update: I haven't found anything that could lead to recent changes in codebase. I'm continuing investigation
EDIT: It seems like this issue happens only if we want to open NewDot after successful sign-in. I think we might have an issue with
ReactNativeActivitystart. Perhaps it's not possible to start this activity when app is in backgroundmateuuszzzzz commentedon Dec 3, 2024
I confirmed that Android blocks activity start, because app is in background. I'm looking for a fix
mountiny commentedon Dec 3, 2024
Nice, great digging!
mateuuszzzzz commentedon Dec 3, 2024
I managed to find a fix, and I'm preparing a PR so that anyone can verify it. I would also like to test the transition between OD and ND, as well as different scenarios where the app is opened from the background.