Skip to content

[HOLD for payment 2025-01-17] [$250] Android/iOS- Highlighted search result go to search page rather that the highlighted detail page #53401

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.69-4
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): testpayment935+735@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/

  2. Go to search router

  3. Write anything eg. "admin" and clear the search again ( to get the highlight on the first result)

  4. Click search icon on keyboard (enter)

Expected Result:

The highlighted item should open the detail page when clicking enter (Mweb behavior)

Actual Result:

The highlighted search result go to search page rather that the highlighted detail page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6682275_1733167237785.Screen_Recording_20241202_221823_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866990715543185912
  • Upwork Job ID: 1866990715543185912
  • Last Price Increase: 2025-01-01
  • Automatic offers:
    • ikevin127 | Reviewer | 105549261
    • huult | Contributor | 105549266
Issue OwnerCurrent Issue Owner: @MitchExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 2, 2024
  2. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Dec 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. luacmartins commented on Dec 2, 2024

    @luacmartins
    Contributor

    Demoting to NAB since it's just highlighting the wrong item. This is likely the offending PR @nyomanjyotisa @Pujan92

  7. 65 remaining items

  8. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    @ikevin127 @MitchExpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. ikevin127 commented on Jan 11, 2025

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A (UX Improvement).

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A (UX Improvement).

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/461096

    Regression Test Proposal

    📱 iOS & Android Native / HybridApp:

    1. Navigate to the Expensify app.
    2. Tap the search icon to open search router.
    3. Input some search characters, e.g. “abc”.
    4. Clear the search input in order to highlight the first item.
    5. Click the search icon / Enter on the device's keyboard to perform action on highlighted item.
    6. Verify that the highlighted item action will do the following:
    • if highlighted item is a report / chat -> will open the report / chat
    • if highlighted item is a recent search -> should perform search again using same recent search details
    • if nothing is highlighted (edge case) -> should close the search router component / modal

    🖥️ 💻📱 Web / mWeb / Desktop:

    1. Navigate to the Expensify Web / mWeb / Desktop app.
    2. Click the search icon to open search router.
    3. Input some search characters, e.g. “abc”.
    4. Clear the search input in order to highlight the first item.
    5. Press Enter to perform action on highlighted item.
    6. Verify that the highlighted item action will do the following:
    • if highlighted item is a report / chat -> will open the report / chat
    • if highlighted item is a recent search -> should perform search again using same recent search details
    • if nothing is highlighted (edge case) -> should close the search router component / modal

    Do we agree 👍 or 👎.

  12. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Jan 14, 2025
  13. MitchExpensify commented on Jan 15, 2025

    @MitchExpensify
    Contributor

    Payment summary:

  14. ikevin127 commented on Jan 18, 2025

    @ikevin127
    Contributor

    cc @MitchExpensify for visibility

  15. MitchExpensify commented on Jan 18, 2025

    @MitchExpensify
    Contributor

    Paid and contracts ended

  16. moved this from Hold for Payment to Done in #expensify-bugson Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions