Skip to content

[HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear #53526

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): didjojdojjdidjo2@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Sign up with a new Gmail account (random email without +).
  3. On onboarding purpose, choose Manage my team's expenses.
  4. Select organization size.
  5. Select an accounting.
  6. Complete the onboarding.

Expected Result:

"Start a free trial" banner and button should appear consistently.

Actual Result:

After the onboarding is complete, "Start a free trial" banner (LHN) and button appear in Concierge.
Then, "Start a free trial" banner" disappears from Concierge report in LHN when #admins room shows up.
When switching to #admins and back to Concierge, "Start a free trial" banner (LHN) and button disappear from Concierge.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6683821_1733279795626.20241204_100133.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864974056851982720
  • Upwork Job ID: 1864974056851982720
  • Last Price Increase: 2024-12-06
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @c3024

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 4, 2024
  2. melvin-bot commented on Dec 4, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Dec 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 4, 2024
  5. melvin-bot commented on Dec 4, 2024

    @melvin-bot

    Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot commented on Dec 4, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Dec 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 35 remaining items

  9. changed the title [-][$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear[/-] [+][HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear[/+] on Jan 21, 2025
  10. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @thesahindia requires payment through NewDot Manual Requests
    • @c3024 requires payment through NewDot Manual Requests
  12. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    @thesahindia / @c3024 @twisterdotcom @thesahindia / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@twisterdotcom)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1864974056851982720/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. twisterdotcom commented on Jan 28, 2025

    @twisterdotcom
    Contributor

    Payment Summary:

    • @c3024 paid $250 via NewDot Manual Requests
    • @thesahindia paid $250 via NewDot Manual Requests
  15. twisterdotcom commented on Jan 28, 2025

    @twisterdotcom
    Contributor

    @c3024 just need the C+ checklist completing please.

  16. c3024 commented on Jan 28, 2025

    @c3024
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: The author of the PR is aware of this.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: No, the bug was not critical enough to warrant a discussion.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • None

    Test:

    Test 1:

    1. Logon to ND with a new email without a '+' in it.
    2. Select the "Manage my team's expenses" onboarding intent > Next.
    3. Select any option in the number of employees step.
    4. Verify that no "Free trial" banner shows up on Concierge chat on LHN nor in the header of the Concierge chat.

    Test 2:

    1. Logon to ND with a new email with a '+' in it.
    2. Select the "Manage my team's expenses" onboarding intent > Next.
    3. Select any option in the number of employees step.
    4. Verify that the "Free trial" banner shows up on Concierge chat on LHN and in the header of the Concierge chat.

    Do we agree 👍 or 👎

  17. JmillsExpensify commented on Jan 29, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @c3024

  18. garrettmknight commented on Jan 29, 2025

    @garrettmknight
    Contributor

    $250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions