You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear #53526
Version Number: 9.0.71-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):didjojdojjdidjo2@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Sign up with a new Gmail account (random email without +).
On onboarding purpose, choose Manage my team's expenses.
Select organization size.
Select an accounting.
Complete the onboarding.
Expected Result:
"Start a free trial" banner and button should appear consistently.
Actual Result:
After the onboarding is complete, "Start a free trial" banner (LHN) and button appear in Concierge.
Then, "Start a free trial" banner" disappears from Concierge report in LHN when #admins room shows up.
When switching to #admins and back to Concierge, "Start a free trial" banner (LHN) and button disappear from Concierge.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear[/-][+][HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear[/+]on Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@thesahindia / @c3024@twisterdotcom@thesahindia / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The author of the PR is aware of this.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No, the bug was not critical enough to warrant a discussion.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
None
Test:
Test 1:
Logon to ND with a new email without a '+' in it.
Select the "Manage my team's expenses" onboarding intent > Next.
Select any option in the number of employees step.
Verify that no "Free trial" banner shows up on Concierge chat on LHN nor in the header of the Concierge chat.
Test 2:
Logon to ND with a new email with a '+' in it.
Select the "Manage my team's expenses" onboarding intent > Next.
Select any option in the number of employees step.
Verify that the "Free trial" banner shows up on Concierge chat on LHN and in the header of the Concierge chat.
Activity
melvin-bot commentedon Dec 4, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Dec 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 4, 2024
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 4, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
35 remaining items
[-][$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear[/-][+][HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear[/+]melvin-bot commentedon Jan 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 21, 2025
@thesahindia / @c3024 @twisterdotcom @thesahindia / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jan 28, 2025
Payment Summary
Upwork Job
BugZero Checklist (@twisterdotcom)
twisterdotcom commentedon Jan 28, 2025
Payment Summary:
twisterdotcom commentedon Jan 28, 2025
@c3024 just need the C+ checklist completing please.
c3024 commentedon Jan 28, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The author of the PR is aware of this.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No, the bug was not critical enough to warrant a discussion.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Test 1:
Test 2:
Do we agree 👍 or 👎
JmillsExpensify commentedon Jan 29, 2025
$250 approved for @c3024
garrettmknight commentedon Jan 29, 2025
$250 approved for @thesahindia