Skip to content

[HOLD for payment 2024-12-30] [$250] Adjust spacing in Global Create menu for Quick Action button #53663

Closed

Description

@shawnborton

Let's adjust the spacing in the Global Create menu so that the Quick action label and button aren't so crammed:

Current:
CleanShot 2024-12-05 at 16 43 42@2x

Proposed:
CleanShot 2024-12-05 at 16 58 18@2x

We can just simply add 12px of top padding and 8px of bottom padding to this element here:
CleanShot 2024-12-05 at 16 58 43@2x

cc @Expensify/design @trjExpensify @JmillsExpensify for visibility, let me know what you think

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864791821196448476
  • Upwork Job ID: 1864791821196448476
  • Last Price Increase: 2024-12-05
  • Automatic offers:
    • suneox | Reviewer | 105251692
    • FitseTLT | Contributor | 105251693
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 5, 2024
  2. melvin-bot commented on Dec 5, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Dec 5, 2024
  4. melvin-bot commented on Dec 5, 2024

    @melvin-bot
  5. changed the title [-]Adjust spacing in Global Create menu for Quick Action button[/-] [+][$250] Adjust spacing in Global Create menu for Quick Action button[/+] on Dec 5, 2024
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 5, 2024
  7. melvin-bot commented on Dec 5, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  8. shawnborton commented on Dec 5, 2024

    @shawnborton
    ContributorAuthor

    Also, this could be a good issue to change up the order and put "Create expense" as the first thing in the list if we want to, cc @danielrvidal

  9. dannymcclain commented on Dec 5, 2024

    @dannymcclain
    Contributor

    Sounds good to me. It is a bit cramped right now. (Also down with making "Create expense" the top option)

  10. FitseTLT commented on Dec 5, 2024

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Adjust spacing in Global Create menu for Quick Action button

    What is the root cause of that problem?

    No spacing given in the label style here

    label: translate('quickAction.header'),

    What changes do you think we should make in order to solve the problem?

    We can add spacing in the label according to the design team suggestion via a margin or a padding: sth like

                labelStyle: [styles.pt3, styles.pb2],
    
    

    And take the expense menu items here to first above the start chat menu item

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

  11. 29 remaining items

  12. dubielzyk-expensify commented on Dec 12, 2024

    @dubielzyk-expensify
    Contributor

    Same

  13. shawnborton commented on Dec 12, 2024

    @shawnborton
    ContributorAuthor

    Cool, I say we do it then.

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 23, 2024
  15. changed the title [-][$250] Adjust spacing in Global Create menu for Quick Action button[/-] [+][HOLD for payment 2024-12-30] [$250] Adjust spacing in Global Create menu for Quick Action button[/+] on Dec 23, 2024
  16. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-30. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    @suneox @adelekennedy @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  19. suneox commented on Dec 30, 2024

    @suneox
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: This is a new feature request.

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other: This is a new feature request.

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other: This is a new feature request.
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A: This is a new feature request.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      N/A: Due to it isn't an impactful bug

  20. adelekennedy commented on Dec 30, 2024

    @adelekennedy
    Contributor

    BZ checklist complete - addressing payments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions