You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-30] [$250] Adjust spacing in Global Create menu for Quick Action button #53663
changed the title [-]Adjust spacing in Global Create menu for Quick Action button[/-][+][$250] Adjust spacing in Global Create menu for Quick Action button[/+]on Dec 5, 2024
changed the title [-][$250] Adjust spacing in Global Create menu for Quick Action button[/-][+][HOLD for payment 2024-12-30] [$250] Adjust spacing in Global Create menu for Quick Action button[/+]on Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@adelekennedy@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: This is a new feature request.
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other: This is a new feature request.
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other: This is a new feature request.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A: This is a new feature request.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Dec 5, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021864791821196448476
[-]Adjust spacing in Global Create menu for Quick Action button[/-][+][$250] Adjust spacing in Global Create menu for Quick Action button[/+]melvin-bot commentedon Dec 5, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)shawnborton commentedon Dec 5, 2024
Also, this could be a good issue to change up the order and put "Create expense" as the first thing in the list if we want to, cc @danielrvidal
dannymcclain commentedon Dec 5, 2024
Sounds good to me. It is a bit cramped right now. (Also down with making "Create expense" the top option)
FitseTLT commentedon Dec 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Adjust spacing in Global Create menu for Quick Action button
What is the root cause of that problem?
No spacing given in the label style here
App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx
Line 436 in 48b80f6
What changes do you think we should make in order to solve the problem?
We can add spacing in the label according to the design team suggestion via a margin or a padding: sth like
And take the expense menu items here to first above the start chat menu item
App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx
Line 520 in 48b80f6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
29 remaining items
dubielzyk-expensify commentedon Dec 12, 2024
Same
shawnborton commentedon Dec 12, 2024
Cool, I say we do it then.
[-][$250] Adjust spacing in Global Create menu for Quick Action button[/-][+][HOLD for payment 2024-12-30] [$250] Adjust spacing in Global Create menu for Quick Action button[/+]melvin-bot commentedon Dec 23, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 23, 2024
@suneox @adelekennedy @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Dec 30, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A: This is a new feature request.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: Due to it isn't an impactful bug
adelekennedy commentedon Dec 30, 2024
BZ checklist complete - addressing payments