Skip to content

[HOLD for payment 2024-12-30] [$125] Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page #53669

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace chat.
  3. Submit two expenses of the same amount.
  4. Go to transaction thread of any expense.
  5. Tap Review duplicates.
  6. Tap Keep this on (any expense).
  7. Go through the flow and proceed to confirmation page.

Expected Result:

Confirm button will not have extra bottom padding.

Actual Result:

Confirm button has extra bottom padding.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021867335169078462217
  • Upwork Job ID: 1867335169078462217
  • Last Price Increase: 2024-12-12
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 5, 2024
  2. melvin-bot commented on Dec 5, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. FitseTLT commented on Dec 5, 2024

    @FitseTLT
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-12-05 23:29:33 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page

    What is the root cause of that problem?

    We haven't set includeSafeAreaPaddingBottom to false on the screenwrapper so it will be true by default

    <ScreenWrapper
    testID={Confirmation.displayName}

    What changes do you think we should make in order to solve the problem?

                includeSafeAreaPaddingBottom={false}
    
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

  4. bernhardoj commented on Dec 6, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There is extra bottom spaces in review duplicate transaction page.

    What is the root cause of that problem?

    The safe area padding-bottom is applied twice.

    <ScreenWrapper
    testID={Confirmation.displayName}
    shouldShowOfflineIndicator
    >
    {({safeAreaPaddingBottomStyle}) => (
    <FullPageNotFoundView shouldShow={shouldShowNotFoundPage}>
    <View style={[styles.flex1, safeAreaPaddingBottomStyle]}>

    Once from inside the ScreenWrapper itself, and once from the safeAreaPaddingBottomStyle that we consume and apply to the View as shown above.

    What changes do you think we should make in order to solve the problem?

    Remove the safeAreaPaddingBottomStyle. This makes the code simpler too.

    <ScreenWrapper
        testID={Confirmation.displayName}
        shouldShowOfflineIndicator
    >
        <FullPageNotFoundView shouldShow={true}>
            <View style={styles.flex1}>
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A, it's a visual UI issue.

  5. melvin-bot commented on Dec 9, 2024

    @melvin-bot

    @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. melvin-bot commented on Dec 11, 2024

    @melvin-bot

    @slafortune Eep! 4 days overdue now. Issues have feelings too...

  7. slafortune commented on Dec 12, 2024

    @slafortune
    Contributor
  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 12, 2024
  9. changed the title [-]Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page[/-] [+][$250] Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page[/+] on Dec 12, 2024
  10. melvin-bot commented on Dec 12, 2024

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 12, 2024
  12. 29 remaining items

  13. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jjcoffee requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
  14. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    @jjcoffee @slafortune @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on Dec 30, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@slafortune)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1867335169078462217/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. jjcoffee commented on Dec 30, 2024

    @jjcoffee
    Contributor

    Not sure where Melv is getting the $250 from since it's $125 in the issue title!

  17. jjcoffee commented on Dec 30, 2024

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: feat: new way to handle insets in the app #53250 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Submit 2 identical money request to a workspace chat
    2. Open one of the expense and press Review duplicate
    3. Proceed to the confirmation page
    4. Verify there is no extra space below the confirm button

    Do we agree 👍 or 👎

  18. slafortune commented on Dec 30, 2024

    @slafortune
    Contributor

    @jjcoffee - Role C+ - owed $125 via NewDot
    @bernhardoj - Role Contributor - owed $125 via NewDot

  19. garrettmknight commented on Dec 30, 2024

    @garrettmknight
    Contributor

    $125 approved for @jjcoffee

  20. bernhardoj commented on Dec 31, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  21. JmillsExpensify commented on Jan 8, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions