You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-30] [$125] Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page #53669
Version Number: 9.0.72-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+kh1311020@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Launch ND or hybrid app.
Go to workspace chat.
Submit two expenses of the same amount.
Go to transaction thread of any expense.
Tap Review duplicates.
Tap Keep this on (any expense).
Go through the flow and proceed to confirmation page.
Expected Result:
Confirm button will not have extra bottom padding.
changed the title [-]Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page[/-][+][$250] Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page[/+]on Dec 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee@slafortune@jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Submit 2 identical money request to a workspace chat
Open one of the expense and press Review duplicate
Proceed to the confirmation page
Verify there is no extra space below the confirm button
Activity
melvin-bot commentedon Dec 5, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Dec 5, 2024
Edited by proposal-police: This proposal was edited at 2024-12-05 23:29:33 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page
What is the root cause of that problem?
We haven't set includeSafeAreaPaddingBottom to false on the screenwrapper so it will be true by default
App/src/pages/TransactionDuplicate/Confirmation.tsx
Lines 93 to 94 in 48b80f6
What changes do you think we should make in order to solve the problem?
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
bernhardoj commentedon Dec 6, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is extra bottom spaces in review duplicate transaction page.
What is the root cause of that problem?
The safe area padding-bottom is applied twice.
App/src/pages/TransactionDuplicate/Confirmation.tsx
Lines 93 to 99 in 3baf965
Once from inside the ScreenWrapper itself, and once from the
safeAreaPaddingBottomStylethat we consume and apply to the View as shown above.What changes do you think we should make in order to solve the problem?
Remove the
safeAreaPaddingBottomStyle. This makes the code simpler too.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A, it's a visual UI issue.
melvin-bot commentedon Dec 9, 2024
@slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 11, 2024
@slafortune Eep! 4 days overdue now. Issues have feelings too...
slafortune commentedon Dec 12, 2024
Checking on this https://expensify.slack.com/archives/C01SKUP7QR0/p1734039216754849
[-]Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page[/-][+][$250] Android & iOS - Review duplicates - Confirm button has extra bottom padding on confirm page[/+]melvin-bot commentedon Dec 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021867335169078462217
29 remaining items
melvin-bot commentedon Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 23, 2024
@jjcoffee @slafortune @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Dec 30, 2024
Payment Summary
Upwork Job
BugZero Checklist (@slafortune)
jjcoffee commentedon Dec 30, 2024
Not sure where Melv is getting the $250 from since it's $125 in the issue title!
jjcoffee commentedon Dec 30, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: feat: new way to handle insets in the app #53250 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
slafortune commentedon Dec 30, 2024
@jjcoffee - Role C+ - owed $125 via NewDot
@bernhardoj - Role Contributor - owed $125 via NewDot
garrettmknight commentedon Dec 30, 2024
$125 approved for @jjcoffee
bernhardoj commentedon Dec 31, 2024
Requested in ND.
JmillsExpensify commentedon Jan 8, 2025
$125 approved for @bernhardoj