You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-21] [Performance] iOS - Investigate slow rerenders in SearchPage #53818
Slow rerenders were reported SearchPage for iOS: #53347 (comment)
What is the impact of this on end-users?
List specific user experiences that will be improved by solving this problem e.g. app boot time, time to for some interaction to complete, etc.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
@mountiny I have done some profiling on iphone 15 pro simulator while logged in with newdotperf account. Here are my findings:
SearchPageBottomTab screen mounting phase takes ~160ms. In comparison, the BaseSidebarScreen (Inbox screen) takes around 10ms.
For SearchPageBottomTab screen, around 100ms is being taken by TransactionListItem component, which is used in as a ListItem in Search component. There's a lot of going on in there but perhaps we could at least reduce the time it takes to be initially rendered.
Around 20ms it takes to render PopoverMenu and DeleteConfirmModal even though they are not visible to the user yet but are still mounted. If we could mount these components only when needed that would be an easy improvement. Thttps://github.com/Expensify/App/blob/886d7ec7301b397f1a08c9878ce23cfc4fb5e08c/src/pages/Search/SearchTypeMenuNarrow.tsx#L230
Yes I'm reading this thread thanks!
However some vacation for us in Poland are incoming so I'm working till the end of this week, and then not working till 30th, so I didn't want to declare that I will fix those.
Please drop any further comments or considerations here, and if there are questions I will try to answer.
Issue is ready for payment but no BZ is assigned. @VictoriaExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA. This is an improvement about performance.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No, we don't need a regression test for this
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
zirgulis commentedon Dec 10, 2024
Hi I'm Povilas from Callstack and I would like to work on this issue.
melvin-bot commentedon Dec 10, 2024
Triggered auto assignment to @marcochavezf (
AutoAssignerNewDotQuality)mountiny commentedon Dec 10, 2024
Related slack thread https://expensify.slack.com/archives/C05LX9D6E07/p1733757346965449
zirgulis commentedon Dec 16, 2024
@mountiny I have done some profiling on iphone 15 pro simulator while logged in with newdotperf account. Here are my findings:
SearchPageBottomTabscreen mounting phase takes ~160ms. In comparison, theBaseSidebarScreen(Inbox screen) takes around 10ms.SearchPageBottomTabscreen, around 100ms is being taken byTransactionListItemcomponent, which is used in as a ListItem in Search component. There's a lot of going on in there but perhaps we could at least reduce the time it takes to be initially rendered.App/src/components/Search/index.tsx
Line 500 in 886d7ec
PopoverMenuandDeleteConfirmModaleven though they are not visible to the user yet but are still mounted. If we could mount these components only when needed that would be an easy improvement. Thttps://github.com/Expensify/App/blob/886d7ec7301b397f1a08c9878ce23cfc4fb5e08c/src/pages/Search/SearchTypeMenuNarrow.tsx#L230mountiny commentedon Dec 18, 2024
Thanks, please keep up diggingk @Kicu might be happy to help too
Kicu commentedon Dec 18, 2024
Yes I'm reading this thread thanks!
However some vacation for us in Poland are incoming so I'm working till the end of this week, and then not working till 30th, so I didn't want to declare that I will fix those.
Please drop any further comments or considerations here, and if there are questions I will try to answer.
15 remaining items
melvin-bot commentedon Jan 21, 2025
Issue is ready for payment but no BZ is assigned. @VictoriaExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Jan 21, 2025
Payment Summary
Upwork Job
BugZero Checklist (@VictoriaExpensify)
melvin-bot commentedon Jan 24, 2025
@marcochavezf, @zirgulis, @VictoriaExpensify, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
zirgulis commentedon Jan 24, 2025
@VictoriaExpensify @mountiny I think we can close this issue?
eh2077 commentedon Jan 24, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA. This is an improvement about performance.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No, we don't need a regression test for this
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
eh2077 commentedon Jan 24, 2025
Requested payment in NewDot
mountiny commentedon Jan 24, 2025
No regression testing so I think $250 for @eh2077 is clear and we can close this
JmillsExpensify commentedon Jan 29, 2025
$250 approved for @eh2077