Skip to content

[HOLD for payment 2025-01-21] [Performance] iOS - Investigate slow rerenders in SearchPage #53818

Closed

Description

@zirgulis

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


What performance issue do we need to solve?

Slow rerenders were reported SearchPage for iOS:
#53347 (comment)

What is the impact of this on end-users?

List specific user experiences that will be improved by solving this problem e.g. app boot time, time to for some interaction to complete, etc.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on Upwork

Issue OwnerCurrent Issue Owner: @zirgulis

Activity

  1. zirgulis commented on Dec 10, 2024

    @zirgulis
    ContributorAuthor

    Hi I'm Povilas from Callstack and I would like to work on this issue.

  2. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (AutoAssignerNewDotQuality)

  3. mountiny commented on Dec 10, 2024

    @mountiny
    Contributor
  4. zirgulis commented on Dec 16, 2024

    @zirgulis
    ContributorAuthor

    @mountiny I have done some profiling on iphone 15 pro simulator while logged in with newdotperf account. Here are my findings:

    1. SearchPageBottomTab screen mounting phase takes ~160ms. In comparison, the BaseSidebarScreen (Inbox screen) takes around 10ms.
    2. For SearchPageBottomTab screen, around 100ms is being taken by TransactionListItem component, which is used in as a ListItem in Search component. There's a lot of going on in there but perhaps we could at least reduce the time it takes to be initially rendered.
      ListItem={ListItem}
    3. Around 20ms it takes to render PopoverMenu and DeleteConfirmModal even though they are not visible to the user yet but are still mounted. If we could mount these components only when needed that would be an easy improvement. Thttps://github.com/Expensify/App/blob/886d7ec7301b397f1a08c9878ce23cfc4fb5e08c/src/pages/Search/SearchTypeMenuNarrow.tsx#L230
  5. mountiny commented on Dec 18, 2024

    @mountiny
    Contributor

    Thanks, please keep up diggingk @Kicu might be happy to help too

  6. Kicu commented on Dec 18, 2024

    @Kicu
    Contributor

    Yes I'm reading this thread thanks!
    However some vacation for us in Poland are incoming so I'm working till the end of this week, and then not working till 30th, so I didn't want to declare that I will fix those.

    Please drop any further comments or considerations here, and if there are questions I will try to answer.

  7. 15 remaining items

  8. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @VictoriaExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  9. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @zirgulis is from an agency-contributor and not due payment
    • Reviewer: @eh2077 owed $250 via NewDot

    BugZero Checklist (@VictoriaExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. melvin-bot commented on Jan 24, 2025

    @melvin-bot

    @marcochavezf, @zirgulis, @VictoriaExpensify, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. zirgulis commented on Jan 24, 2025

    @zirgulis
    ContributorAuthor

    @VictoriaExpensify @mountiny I think we can close this issue?

  12. eh2077 commented on Jan 24, 2025

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA. This is an improvement about performance.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    No, we don't need a regression test for this

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

  13. eh2077 commented on Jan 24, 2025

    @eh2077
    Contributor

    Requested payment in NewDot

  14. mountiny commented on Jan 24, 2025

    @mountiny
    Contributor

    No regression testing so I think $250 for @eh2077 is clear and we can close this

  15. JmillsExpensify commented on Jan 29, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions