Skip to content

[HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Profile - Invalid second contact method is added and displayed as ready to verify. #53819

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.73-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5320066&group_by=cases:section_id&group_order=asc&group_id=229064
Email or phone of affected tester (no customers): ibellicotest+86@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Tap on "Settings" and select "Profile"
  3. Open the "Contact Method" tab.
  4. Tap on "New Contact Method"
  5. Complete with an Email with an existing account.
  6. Wait for the magic code to be received and type it.
  7. Verify that an error message is displayed, showing that the account can´t be added as contact method.
  8. Close the error message and tap on the arrow on the top left corner.
  9. Verify that the account wasn´t added as second contact method.

Expected Result:

Invalid Email or Email with existing account, shouldn´t be added as secondary contact method after the error message is closed.

Actual Result:

After the user receives and closes an error message, showing that an account can´t be added as contact method, the account is added anyway and is displayed as ready to verify. The user receives a magic code to verify the account, but all the codes received are rejected.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6689509_1733797910567.Contact.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 10, 2024
  2. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 10, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MonilBhavsar commented on Dec 10, 2024

    @MonilBhavsar
    Contributor

    Commented on the suspicious PR #53462

  7. thesahindia commented on Dec 10, 2024

    @thesahindia
    Member

    The issue seems to be a bit different. I am getting a different error when I follow the steps. Also I couldn't add the contact method.

    https://github.com/user-attachments/assets/44d22c4a-57f6-4e45-a906-e1c0c7884321

    cc: @MonilBhavsar

    Edit: I was able to repro. The error is different but the issue is reproducible.

    Note: This is not a regression from #53462

  8. Shahidullah-Muffakir commented on Dec 10, 2024

    @Shahidullah-Muffakir
    Contributor

    Issue still produceable after reverting the PR.

    Screen.20Recording.202024-12-10.20at.204.mp4
  9. 24 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 10, 2024
  11. changed the title [-] Profile - Invalid second contact method is added and displayed as ready to verify.[/-] [+][HOLD for payment 2024-12-17] Profile - Invalid second contact method is added and displayed as ready to verify.[/+] on Dec 10, 2024
  12. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @brunovjk requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    @brunovjk @sakluger @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. MonilBhavsar commented on Dec 11, 2024

    @MonilBhavsar
    Contributor

    We can close this. This was handled as a regression. Thank you all for taking care of this 🙌

  16. changed the title [-][HOLD for payment 2024-12-17] Profile - Invalid second contact method is added and displayed as ready to verify.[/-] [+][HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Profile - Invalid second contact method is added and displayed as ready to verify.[/+] on Dec 12, 2024
  17. melvin-bot commented on Dec 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @brunovjk requires payment (Needs manual offer from BZ)
  18. melvin-bot commented on Dec 12, 2024

    @melvin-bot

    @brunovjk @sakluger @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions